Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2629033002: Add test for Flash information on chrome://version page. (Closed)

Created:
3 years, 11 months ago by Greg K
Modified:
3 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for Flash information on chrome://version page. This adds a test for the Flash information displayed on the chrome://version page. The test cannot check the actual version or location as it varies per build, or is disabled in Chromium builds. BUG=680273 Review-Url: https://codereview.chromium.org/2629033002 Cr-Commit-Position: refs/heads/master@{#443334} Committed: https://chromium.googlesource.com/chromium/src/+/d3dcfef1ef6dd498d0c77412742e654814c5a210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Greg K
PTAL. Thanks, Greg
3 years, 11 months ago (2017-01-11 23:19:16 UTC) #2
Greg K
PTAL. Thanks, Greg
3 years, 11 months ago (2017-01-12 19:44:03 UTC) #10
Nico
lgtm
3 years, 11 months ago (2017-01-12 19:54:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629033002/1
3 years, 11 months ago (2017-01-12 19:56:43 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 20:06:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3dcfef1ef6dd498d0c77412742e...

Powered by Google App Engine
This is Rietveld 408576698