Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2629003003: Revert of Adds animated touch point and the hint box for touch calibration UX (Closed)

Created:
3 years, 11 months ago by dschuyler
Modified:
3 years, 11 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds animated touch point and the hint box for touch calibration UX (patchset #4 id:120001 of https://codereview.chromium.org/2600213002/ ) Reason for revert: Hoping to clear up issue on builder here: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/18918 -- sheriff Original issue's description: > Adds animated touch point and the hint box for touch calibration UX > > - Adds the circular throbbing touch point view that the user interacts > with during touch calibration. > - Adds the hint box view that contains the hint message as given in the > UX specs. > (https://drive.google.com/file/d/0B_2Uyb2Rhx2OU0FIbXUyMkhMZlE/view) > - Adds required resource strings for hint box messages. > > Working protottpe(The video is the entire prototype. This change only > involves adding the touch point and hint box.): > https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1QVR0WFJYdUY2SmZTdWdUVFNSM0F5WDF4YlBn/view > > Screenshot of how it looks on different DPI screens: > https://screenshot.googleplex.com/ND5d9v0799y.png > > Screenshot for RTL: > https://screenshot.googleplex.com/Xd3PyAYbDTV.png > > BUG=634166 > COMPONENT=Touch Calibration, ChromeOS, UI Strings > > Review-Url: https://codereview.chromium.org/2600213002 > Cr-Commit-Position: refs/heads/master@{#443000} > Committed: https://chromium.googlesource.com/chromium/src/+/2f631d1860f7dfcf100b5a6bef46263cd7a4e698 TBR=oshima@chromium.org,stevenjb@chromium.org,malaykeshav@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634166 Review-Url: https://codereview.chromium.org/2629003003 Cr-Commit-Position: refs/heads/master@{#443088} Committed: https://chromium.googlesource.com/chromium/src/+/914245e19d7a89a64f2d61b0e4388161635cae20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -311 lines) Patch
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.h View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc View 5 chunks +1 line, -291 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dschuyler
Created Revert of Adds animated touch point and the hint box for touch calibration UX
3 years, 11 months ago (2017-01-12 00:39:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629003003/1
3 years, 11 months ago (2017-01-12 00:40:41 UTC) #3
malaykeshav
lgtm
3 years, 11 months ago (2017-01-12 00:40:50 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 00:43:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/914245e19d7a89a64f2d61b0e438...

Powered by Google App Engine
This is Rietveld 408576698