Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2628983002: [layoutng] Slightly simplify some code (Closed)

Created:
3 years, 11 months ago by cbiesinger
Modified:
3 years, 11 months ago
Reviewers:
atotic
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Slightly simplify some code This is my review comment from https://codereview.chromium.org/2616093004/ R=atotic@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2628983002 Cr-Commit-Position: refs/heads/master@{#443045} Committed: https://chromium.googlesource.com/chromium/src/+/6d25e92003589f50192f951c654dc7ee98bad15c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
cbiesinger
3 years, 11 months ago (2017-01-11 21:25:10 UTC) #1
atotic
lgtm
3 years, 11 months ago (2017-01-11 22:44:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628983002/1
3 years, 11 months ago (2017-01-11 22:50:32 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:13:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6d25e92003589f50192f951c654d...

Powered by Google App Engine
This is Rietveld 408576698