Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2628973004: Add test for graceful GOAWAY. (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for graceful GOAWAY. Review-Url: https://codereview.chromium.org/2628973004 Cr-Commit-Position: refs/heads/master@{#443282} Committed: https://chromium.googlesource.com/chromium/src/+/1fc7b35ee14c30ec55fbdb6612821804f49c3afa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 11 months ago (2017-01-12 15:37:15 UTC) #6
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-12 17:45:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628973004/1
3 years, 11 months ago (2017-01-12 17:45:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:51:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1fc7b35ee14c30ec55fbdb661282...

Powered by Google App Engine
This is Rietveld 408576698