Issue 2628963005: String.prototype.anchor and others should not cause side effects.

Issue 2628963005: String.prototype.anchor and others should not cause side effects. (Closed)

Created:
3 years, 11 months ago by Yang

Modified:
3 years, 11 months ago

Reviewers:
jgruber

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

String.prototype.anchor and others should not cause side effects. R=jgruber@chromium.org BUG=v8::5836 Review-Url: https://codereview.chromium.org/2628963005 Cr-Commit-Position: refs/heads/master@{#42308} Committed: https://chromium.googlesource.com/v8/v8/+/865b5e579561146a583cf2f9cb7266a6498d12f7

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/js/string.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-5836.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628963005/1

3 years, 11 months ago (2017-01-13 08:11:46 UTC) #4

commit-bot: I haz the power

3 years, 11 months ago (2017-01-13 08:38:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/865b5e579561146a583cf2f9cb7266a6498...