Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2628963002: Revert of Enable creation of offscreen contexts which own their backing surface. (Closed)

Created:
3 years, 11 months ago by mthiesse
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, haraken, jam, kalyank, mlamouri+watch-content_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable creation of offscreen contexts which own their backing surface. (patchset #12 id:220001 of https://codereview.chromium.org/2586803003/ ) Reason for revert: Causes out-of-order frames and tearing in WebVR. Original issue's description: > Enable creation of offscreen contexts which own their backing surface. > > This is adapted from bajones's patch from issue 2461803002 at patchset 1 > (http://crrev.com/2461803002#ps1) > > Uses the own_offscreen_surface flag with WebGL contexts when WebVR is enabled, > to allow the surface to be swapped out with a compatible one if used for VR > presentation. > > Includes support for canvas attributes such as "antialias", and adds a "low > priority" GL context option so that postprocessing such as in WebVR frame > submit at normal priority won't get blocked on the next frame being drawn. > > BUG=655722 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2586803003 > Cr-Commit-Position: refs/heads/master@{#442448} > Committed: https://chromium.googlesource.com/chromium/src/+/46b9f6aaaf5851014c2474365734e71ffe9367a0 TBR=aelias@chromium.org,bajones@chromium.org,dcheng@chromium.org,jbauman@chromium.org,klausw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=655722 Review-Url: https://codereview.chromium.org/2628963002 Cr-Commit-Position: refs/heads/master@{#443039} Committed: https://chromium.googlesource.com/chromium/src/+/a08094dee4ad5de452d011f1bdd9714815739348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -125 lines) Patch
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +5 lines, -16 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/service_utils.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 chunk +1 line, -26 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/gl/gl_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_context_egl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_surface_egl.cc View 8 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mthiesse
Created Revert of Enable creation of offscreen contexts which own their backing surface.
3 years, 11 months ago (2017-01-11 19:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628963002/1
3 years, 11 months ago (2017-01-11 19:49:32 UTC) #3
klausw
On 2017/01/11 19:48:47, mthiesse wrote: > Created Revert of Enable creation of offscreen contexts which ...
3 years, 11 months ago (2017-01-11 20:07:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211236)
3 years, 11 months ago (2017-01-11 20:09:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628963002/1
3 years, 11 months ago (2017-01-11 20:19:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/192434)
3 years, 11 months ago (2017-01-11 20:29:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628963002/1
3 years, 11 months ago (2017-01-11 20:45:46 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:00:35 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a08094dee4ad5de452d011f1bdd9...

Powered by Google App Engine
This is Rietveld 408576698