[Android] Explicitly check that devices are online during test set up.

[Android] Explicitly check that devices are online during test set up.

In rare cases, devices time out on the first real command sent to them.
On swarming, the total time required for this timeout can exceed that
amount of time allotted for the containing task to finish. This is bad.

This change checks that the device is fully booted before attempting to
do anything else with it. The commands this runs should ensure that we
can run basic commands on the device and that the package manager is
running. This all runs with a relatively short timeout, so we should
be able to identify a potentially problematic device before hitting
the swarming timeout.

BUG=664308
Review-Url: https://codereview.chromium.org/2628953003
Cr-Commit-Position: refs/heads/master@{#443390}
Committed: https://chromium.googlesource.com/chromium/src/+/e9408cc6c29f9476a7a76d07ecefc6f1d7b3fcdb

[jbudorick, 2017-01-12 16:38:48]

jbudorick@chromium.org changed reviewers:
+ bpastene@chromium.org, katthomas@chromium.org

[bpastene, 2017-01-12 21:11:28]

lgtm

[jbudorick, 2017-01-12 21:23:33]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:24:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:40:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484256213309880, "parent_rev":
"5f298498d0bc01765cec4bbd323e2d55f7609b35", "commit_rev":
"e9408cc6c29f9476a7a76d07ecefc6f1d7b3fcdb"}

[commit-bot: I haz the power, 2017-01-12 22:41:14]

Description was changed from

==========
[Android] Explicitly check that devices are online during test set up.

In rare cases, devices time out on the first real command sent to them.
On swarming, the total time required for this timeout can exceed that
amount of time allotted for the containing task to finish. This is bad.

This change checks that the device is fully booted before attempting to
do anything else with it. The commands this runs should ensure that we
can run basic commands on the device and that the package manager is
running. This all runs with a relatively short timeout, so we should
be able to identify a potentially problematic device before hitting
the swarming timeout.

BUG=664308
==========

to

==========
[Android] Explicitly check that devices are online during test set up.

In rare cases, devices time out on the first real command sent to them.
On swarming, the total time required for this timeout can exceed that
amount of time allotted for the containing task to finish. This is bad.

This change checks that the device is fully booted before attempting to
do anything else with it. The commands this runs should ensure that we
can run basic commands on the device and that the package manager is
running. This all runs with a relatively short timeout, so we should
be able to identify a potentially problematic device before hitting
the swarming timeout.

BUG=664308

Review-Url: https://codereview.chromium.org/2628953003
Cr-Commit-Position: refs/heads/master@{#443390}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9408cc6c29f9476a7a76d07ecef...
==========

[commit-bot: I haz the power, 2017-01-12 22:41:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9408cc6c29f9476a7a76d07ecef...