Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2628943002: Fix issue with setUserVisibleHint() being called too early. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 NOTRY=true Review-Url: https://codereview.chromium.org/2628943002 Cr-Commit-Position: refs/heads/master@{#443026} Committed: https://chromium.googlesource.com/chromium/src/+/f4f7c520efaa03663cd8c19662f915bf313bfe7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
Alexei Svitkine (slow)
PTAL
3 years, 11 months ago (2017-01-11 19:34:30 UTC) #1
Ted C
lgtm
3 years, 11 months ago (2017-01-11 19:36:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628943002/1
3 years, 11 months ago (2017-01-11 19:37:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/192448)
3 years, 11 months ago (2017-01-11 19:52:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628943002/1
3 years, 11 months ago (2017-01-11 20:06:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/211239)
3 years, 11 months ago (2017-01-11 20:17:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628943002/1
3 years, 11 months ago (2017-01-11 20:28:54 UTC) #17
Alexei Svitkine (slow)
Setting NOTRY=true because cq is not landing it due failing "compile (without patch) " step ...
3 years, 11 months ago (2017-01-11 20:29:29 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:44:53 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4f7c520efaa03663cd8c19662f9...

Powered by Google App Engine
This is Rietveld 408576698