|
|
Created:
3 years, 11 months ago by Alexei Svitkine (slow) Modified:
3 years, 11 months ago Reviewers:
Ted C CC:
chromium-reviews, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix issue with setUserVisibleHint() being called too early.
This caused a crash bug in FRE code on some versions of
Android where setUserVisibleHint() gets called before
onViewCreated().
This was broken by my CL from this morning:
https://codereview.chromium.org/2561433002
BUG=632199
NOTRY=true
Review-Url: https://codereview.chromium.org/2628943002
Cr-Commit-Position: refs/heads/master@{#443026}
Committed: https://chromium.googlesource.com/chromium/src/+/f4f7c520efaa03663cd8c19662f915bf313bfe7b
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
PTAL
Description was changed from ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 TBR=tedchoc@chromium.org ========== to ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 TBR=tedchoc@chromium.org ==========
lgtm
Description was changed from ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 TBR=tedchoc@chromium.org ========== to ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 ==========
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 ========== to ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 NOTRY=true ==========
The CQ bit was checked by asvitkine@chromium.org
The CQ bit was unchecked by asvitkine@chromium.org
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Setting NOTRY=true because cq is not landing it due failing "compile (without patch) " step due to lint error in some translated grit strings. :(
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1484166503199630, "parent_rev": "829fa5d5abc060c3fca83c2324bb8ce47a43361c", "commit_rev": "f4f7c520efaa03663cd8c19662f915bf313bfe7b"}
Message was sent while issue was closed.
Description was changed from ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 NOTRY=true ========== to ========== Fix issue with setUserVisibleHint() being called too early. This caused a crash bug in FRE code on some versions of Android where setUserVisibleHint() gets called before onViewCreated(). This was broken by my CL from this morning: https://codereview.chromium.org/2561433002 BUG=632199 NOTRY=true Review-Url: https://codereview.chromium.org/2628943002 Cr-Commit-Position: refs/heads/master@{#443026} Committed: https://chromium.googlesource.com/chromium/src/+/f4f7c520efaa03663cd8c19662f9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f4f7c520efaa03663cd8c19662f9... |