Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h

Issue 262893002: Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop (refactored) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
diff --git a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
index 34f2783a73fb34c0b661952945e0cb54e0d481bf..653035a363165b3888cc721f5df06777a049be18 100644
--- a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
+++ b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
@@ -45,23 +45,16 @@ class X11WholeScreenMoveLoop : public ui::PlatformEventDispatcher {
// by pressing escape), then returns false.
bool RunMoveLoop(aura::Window* window, gfx::NativeCursor cursor);
- // Updates the cursor while the move loop is running.
- void UpdateCursor(gfx::NativeCursor cursor);
-
// Ends the RunMoveLoop() that's currently in progress.
void EndMoveLoop();
+ // Returns true if still running a nested message loop, false otherwise.
+ bool in_move_loop() const { return in_move_loop_; }
+
// Sets an image to be used during the drag.
void SetDragImage(const gfx::ImageSkia& image, gfx::Vector2dF offset);
private:
- // Grabs the pointer and keyboard, setting the mouse cursor to |cursor|.
- // Returns true if the grab was successful.
- bool GrabPointerAndKeyboard(gfx::NativeCursor cursor);
-
- // Creates an input-only window to be used during the drag.
- Window CreateDragInputWindow(XDisplay* display);
-
// Creates a window to show the drag image during the drag.
void CreateDragImageWindow();
@@ -80,11 +73,6 @@ class X11WholeScreenMoveLoop : public ui::PlatformEventDispatcher {
bool should_reset_mouse_flags_;
- // An invisible InputOnly window . We create this window so we can track the
- // cursor wherever it goes on screen during a drag, since normal windows
- // don't receive pointer motion events outside of their bounds.
- ::Window grab_input_window_;
-
base::Closure quit_closure_;
// Keeps track of whether the move-loop is cancled by the user (e.g. by

Powered by Google App Engine
This is Rietveld 408576698