Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2628923006: Deprecate all -internal-media-controls-* currently expose to web contents. (Closed)

Created:
3 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 11 months ago
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate all -internal-media-controls-* currently expose to web contents. Exhaustive list is: -internal-media-controls-cast-button -internal-media-controls-overlay-cast-button -internal-media-controls-text-track-list -internal-media-controls-text-track-list-item -internal-media-controls-text-track-list-item-input -internal-media-controls-text-track-list-kind-captions -internal-media-controls-text-track-list-kind-subtitles Chrome Status entries are: - https://www.chromestatus.com/feature/5734009183141888 - https://www.chromestatus.com/feature/5714245488476160 - https://www.chromestatus.com/feature/5661431349379072 BUG=678285 R=foolip@chromium.org, isherman@chromium.org Review-Url: https://codereview.chromium.org/2628923006 Cr-Commit-Position: refs/heads/master@{#444346} Committed: https://chromium.googlesource.com/chromium/src/+/37af6af68b5ef43dc3b2d588ea7a2a56a678b351

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -79 lines) Patch
A third_party/WebKit/LayoutTests/media/deprecated-css-selectors.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/deprecated-css-selectors-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 2 4 chunks +112 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mlamouri (slow - plz ping)
PTAL
3 years, 11 months ago (2017-01-13 13:58:21 UTC) #1
mlamouri (slow - plz ping)
-isherman@ -foolip@ +jochen@
3 years, 11 months ago (2017-01-17 09:42:52 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-17 09:55:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628923006/40001
3 years, 11 months ago (2017-01-18 10:29:17 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 13:54:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/37af6af68b5ef43dc3b2d588ea7a...

Powered by Google App Engine
This is Rietveld 408576698