Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2628883004: cc: Use weak ptr for async read pixel queries. (Closed)

Created:
3 years, 11 months ago by reveman
Modified:
3 years, 11 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Use weak ptr for async read pixel queries. This cleans up the async read pixel code a bit by using weak ptrs instead of cancelable callbacks. BUG=678234 TEST=cc_unittests CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2628883004 Cr-Commit-Position: refs/heads/master@{#443347} Committed: https://chromium.googlesource.com/chromium/src/+/aec7d45bff4c7a8a697034754600f264988714ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M cc/output/gl_renderer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +6 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
reveman
3 years, 11 months ago (2017-01-12 19:26:07 UTC) #7
danakj
LGTM thanks!
3 years, 11 months ago (2017-01-12 20:08:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628883004/1
3 years, 11 months ago (2017-01-12 20:33:45 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 20:42:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aec7d45bff4c7a8a697034754600...

Powered by Google App Engine
This is Rietveld 408576698