Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2628883002: Move CustomLauncherPageContents from apps to c/b/ui/app_list (Closed)

Created:
3 years, 11 months ago by michaelpg
Modified:
3 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Matt Giuca, tfarina, Rahul Chaturvedi, tbarzic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CustomLauncherPageContents from apps to c/b/ui/app_list This is the most Chrome-dependent part of //apps, and is only used for the app list in Chrome, so why not move it to chrome/browser/ui/app_list? This enables us to make the rest of the //apps code independent of Chrome so it can be used for app_shell. Alternatively, we could make custom_launcher_page_contents.cc not depend on Chrome (it's mostly for extensions::ChromeExtensionWebContentsObserver), but that's probably better off being lumped into a larger task to move app_list out of chrome if that should become a goal. BUG=679971 R=benwells@chromium.org Review-Url: https://codereview.chromium.org/2628883002 Cr-Commit-Position: refs/heads/master@{#443286} Committed: https://chromium.googlesource.com/chromium/src/+/b2e0703838bc7140c4129c491085a1da55cacbbf

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -235 lines) Patch
M apps/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D apps/custom_launcher_page_contents.h View 1 chunk +0 lines, -84 lines 0 comments Download
D apps/custom_launcher_page_contents.cc View 1 chunk +0 lines, -134 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/app_list/custom_launcher_page_contents.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/app_list/custom_launcher_page_contents.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
michaelpg
Ben, does this seem OK to you?
3 years, 11 months ago (2017-01-11 16:29:40 UTC) #1
michaelpg
3 years, 11 months ago (2017-01-11 16:29:58 UTC) #2
benwells
lgtm BTW thanks for working on this!
3 years, 11 months ago (2017-01-12 06:12:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628883002/20001
3 years, 11 months ago (2017-01-12 16:53:13 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:57:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b2e0703838bc7140c4129c491085...

Powered by Google App Engine
This is Rietveld 408576698