Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2628873006: MacViews: Make AXPlatformNodeCocoa consistent with NSAccessibilityConstants.h. (Closed)

Created:
3 years, 11 months ago by Patti Lor
Modified:
3 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Make AXPlatformNodeCocoa consistent with NSAccessibilityConstants.h. Make sure all NSAccessibilityAttributes are the correct types as specified in the 10.12 SDK (see attached bug), and fix the order of methods to be the same. BUG=678898 Review-Url: https://codereview.chromium.org/2628873006 Cr-Commit-Position: refs/heads/master@{#443819} Committed: https://chromium.googlesource.com/chromium/src/+/266a86c94d34f3c7c3d22ee00624636b801f80d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -44 lines) Patch
M ui/accessibility/platform/ax_platform_node_mac.mm View 5 chunks +47 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Patti Lor
Hi dmazzoni@, PTAL. Only a couple of attribute types needed changing; specifically TopUIElement, Window, Enabled, ...
3 years, 11 months ago (2017-01-13 04:15:23 UTC) #6
dmazzoni
lgtm
3 years, 11 months ago (2017-01-13 18:12:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628873006/1
3 years, 11 months ago (2017-01-15 23:08:02 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-15 23:27:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/266a86c94d34f3c7c3d22ee00624...

Powered by Google App Engine
This is Rietveld 408576698