Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2628863005: Revert of Part two of fallback crash handler for Crashpad handler process. (Closed)

Created:
3 years, 11 months ago by Sigurður Ásgeirsson
Modified:
3 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, kalyank, Mark Mentovai
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Part two of fallback crash handler for Crashpad handler process. (patchset #11 id:220001 of https://codereview.chromium.org/2611393002/ ) Reason for revert: Breaks components_unittests on Win10. Original issue's description: > Part two of fallback crash handler for Crashpad handler process. > > This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it. > After this, the dump is dropped into the Crashpad database for eventual upload. > > BUG=678959 > > Review-Url: https://codereview.chromium.org/2611393002 > Cr-Commit-Position: refs/heads/master@{#443249} > Committed: https://chromium.googlesource.com/chromium/src/+/92651104e939dbe94378a607e7acd381ca394fd3 TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=678959 Review-Url: https://codereview.chromium.org/2628863005 Cr-Commit-Position: refs/heads/master@{#443290} Committed: https://chromium.googlesource.com/chromium/src/+/65d726a3d10b3a55ea563fb7089a34f129cd95f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -713 lines) Patch
M components/crash/content/app/BUILD.gn View 3 chunks +3 lines, -12 lines 0 comments Download
D components/crash/content/app/fallback_crash_handler_win.h View 1 chunk +0 lines, -60 lines 0 comments Download
D components/crash/content/app/fallback_crash_handler_win.cc View 1 chunk +0 lines, -448 lines 0 comments Download
D components/crash/content/app/fallback_crash_handler_win_unittest.cc View 1 chunk +0 lines, -193 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sigurður Ásgeirsson
Created Revert of Part two of fallback crash handler for Crashpad handler process.
3 years, 11 months ago (2017-01-12 18:10:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628863005/1
3 years, 11 months ago (2017-01-12 18:11:37 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 18:12:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65d726a3d10b3a55ea563fb7089a...

Powered by Google App Engine
This is Rietveld 408576698