Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2628863003: Fix remote trace recording via chrome://inspect?tracing (Closed)

Created:
3 years, 11 months ago by caseq
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix remote trace recording via chrome://inspect?tracing This was regressed in two different places, first by https://codereview.chromium.org/2515903002 and then by https://codereview.chromium.org/2607833002 BUG=680170

Patch Set 1 #

Patch Set 2 : drive by: stronger check for front-end URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 9 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
caseq
3 years, 11 months ago (2017-01-12 00:48:20 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-12 01:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628863003/20001
3 years, 11 months ago (2017-01-12 01:16:02 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 02:41:04 UTC) #8
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698