Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2515903002: DevTools: webui receives document load message upon navigation, even for cross-domain navigations. … (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: webui receives document load message upon navigation, even for cross-domain navigations. Mitigate it in the devtools ui bindings. BUG=641246 Committed: https://crrev.com/8f26cf4991ebfaf35bf64d976d66d97b8edba360 Cr-Commit-Position: refs/heads/master@{#433363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 1 month ago (2016-11-18 23:31:11 UTC) #2
dgozman
lgtm
4 years, 1 month ago (2016-11-18 23:42:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2515903002/1
4 years, 1 month ago (2016-11-18 23:43:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 01:06:48 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:08:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f26cf4991ebfaf35bf64d976d66d97b8edba360
Cr-Commit-Position: refs/heads/master@{#433363}

Powered by Google App Engine
This is Rietveld 408576698