Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2628843003: Remove unused CJS_Object::ExitInstance() method (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused CJS_Object::ExitInstance() method All the work happens in the virtual dtors like it should. Review-Url: https://codereview.chromium.org/2628843003 Committed: https://pdfium.googlesource.com/pdfium/+/ffdfbb9ec274785e01dbdb64e9eef624fc1fb2e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M fpdfsdk/javascript/JS_Define.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Object.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, quick review.
3 years, 11 months ago (2017-01-11 23:25:30 UTC) #4
dsinclair
lgtm
3 years, 11 months ago (2017-01-12 14:29:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628843003/1
3 years, 11 months ago (2017-01-12 14:29:32 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 14:29:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ffdfbb9ec274785e01dbdb64e9eef624fc1f...

Powered by Google App Engine
This is Rietveld 408576698