Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 2628833003: Remove no longer used GPU.CheckFramebufferValidDuration (Closed)

Created:
3 years, 11 months ago by ericrk
Modified:
3 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove no longer used GPU.CheckFramebufferValidDuration I got the data I wanted from this UMA, and it appears to be causing performance regressions. Removing. R=isherman@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2628833003 Cr-Commit-Position: refs/heads/master@{#443317} Committed: https://chromium.googlesource.com/chromium/src/+/815414a7c5ce12982f36ec9c45f59e19cf003f22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
ericrk
3 years, 11 months ago (2017-01-11 21:04:15 UTC) #6
Zhenyao Mo
lgtm Thanks for cleaning this up
3 years, 11 months ago (2017-01-11 21:24:02 UTC) #9
Ilya Sherman
LGTM, thanks.
3 years, 11 months ago (2017-01-12 00:15:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628833003/1
3 years, 11 months ago (2017-01-12 19:08:18 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:14:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/815414a7c5ce12982f36ec9c45f5...

Powered by Google App Engine
This is Rietveld 408576698