Keyboard event should not insert a character at selection if selection doesn't have focus

Keyboard event should not insert a character at selection if selection doesn't have focus

This patch makes Blink not to insert a character at selection if selection
doesn't have focus to align with other browser's behavior.

The test expectation of "keypress-focus-change.html" is changed for moving focus
on "keydown" event handler. In Firefox, it still insert a character at selection
but Blink and Edge don't. On manual focus moving, Firefox also doesn't insert
character.

To unblock CL[1] as soon as possible, this patch uses ugly test case. Following
patch will fix it.

[1] http://crrev.com/2616623002: Do not send redundant
ViewHostMsg_TextInputStateChanged-message

BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html

Review-Url: https://codereview.chromium.org/2628763003
Cr-Commit-Position: refs/heads/master@{#443189}
Committed: https://chromium.googlesource.com/chromium/src/+/c5138fa204cedceffaf7a7e777529a9a5d69964c

[yosin_UTC9, 2017-01-11 05:19:09]

Description was changed from

==========
2017-01-11T14:15:42

2017-01-11T14:15:25

BUG=
==========

to

==========
Keyboard event should not insert a character at selection if selection doesn't
have focus


BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html
==========

[yosin_UTC9, 2017-01-11 05:19:24]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 05:19:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 06:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 06:09:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-01-11 06:45:35]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 06:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 07:58:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 07:58:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-01-12 04:26:40]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 04:27:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-12 08:31:01]

xiaochengh@chromium.org changed reviewers:
+ xiaochengh@chromium.org

[Xiaocheng, 2017-01-12 08:31:02]

https://codereview.chromium.org/2628763003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/input/keyboard_event_without_focus.html
(right):

https://codereview.chromium.org/2628763003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/input/keyboard_event_without_focus.html:20:
// Insert |textField.value| to HTML for verification
I think we should modify assert_selection to report the actual value of <input>
(and probably <textarea>).

I'm not against it if you want to unblock
https://codereview.chromium.org/2616623002 asap and fix the hack here later.

[commit-bot: I haz the power, 2017-01-12 08:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 08:46:34]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-12 09:10:01]

Description was changed from

==========
Keyboard event should not insert a character at selection if selection doesn't
have focus


BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html
==========

to

==========
Keyboard event should not insert a character at selection if selection doesn't
have focus

This patch makes Blink not to insert a character at selection if selection
doesn't have focus to align with other browser's behavior.

The test expectation of "keypress-focus-change.html" is changed for moving focus
on "keydown" event handler. In Firefox, it still insert a character at selection
but Blink and Edge don't. On manual focus moving, Firefox also doesn't insert
character.

To unblock CL[1] as soon as possible, this patch uses ugly test case. Following
patch will fix it.

[1] http://crrev.com/2616623002: Do not send redundant
ViewHostMsg_TextInputStateChanged-message

BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html
==========

[yosin_UTC9, 2017-01-12 09:10:01]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2017-01-12 09:10:53]

PTAL


I attempt to update |assert_selection()|, but it takes time. So, I would like to
land this patch then fix the test.

Sorry for ugly patch...

[Xiaocheng, 2017-01-12 09:12:08]

On 2017/01/12 at 09:10:53, yosin wrote:
> PTAL
> 
> 
> I attempt to update |assert_selection()|, but it takes time. So, I would like
to land this patch then fix the test.
> 
> Sorry for ugly patch...

OK, lgtm then.

[yosin_UTC9, 2017-01-12 09:22:16]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-01-12 09:22:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 09:26:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484212936149230,
"parent_rev": "2dcda31b3f6d9e8cf588f0c233d9c8c7cb9b4521", "commit_rev":
"c5138fa204cedceffaf7a7e777529a9a5d69964c"}

[commit-bot: I haz the power, 2017-01-12 09:27:27]

Description was changed from

==========
Keyboard event should not insert a character at selection if selection doesn't
have focus

This patch makes Blink not to insert a character at selection if selection
doesn't have focus to align with other browser's behavior.

The test expectation of "keypress-focus-change.html" is changed for moving focus
on "keydown" event handler. In Firefox, it still insert a character at selection
but Blink and Edge don't. On manual focus moving, Firefox also doesn't insert
character.

To unblock CL[1] as soon as possible, this patch uses ugly test case. Following
patch will fix it.

[1] http://crrev.com/2616623002: Do not send redundant
ViewHostMsg_TextInputStateChanged-message

BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html
==========

to

==========
Keyboard event should not insert a character at selection if selection doesn't
have focus

This patch makes Blink not to insert a character at selection if selection
doesn't have focus to align with other browser's behavior.

The test expectation of "keypress-focus-change.html" is changed for moving focus
on "keydown" event handler. In Firefox, it still insert a character at selection
but Blink and Edge don't. On manual focus moving, Firefox also doesn't insert
character.

To unblock CL[1] as soon as possible, this patch uses ugly test case. Following
patch will fix it.

[1] http://crrev.com/2616623002: Do not send redundant
ViewHostMsg_TextInputStateChanged-message

BUG=89026
TEST=LayoutTests/editing/input/keyboard_event_without_focus.html

Review-Url: https://codereview.chromium.org/2628763003
Cr-Commit-Position: refs/heads/master@{#443189}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5138fa204cedceffaf7a7e77752...
==========

[commit-bot: I haz the power, 2017-01-12 09:27:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c5138fa204cedceffaf7a7e77752...

[yoichio, 2017-01-13 02:04:07]

https://codereview.chromium.org/2628763003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/input/keyboard_event_without_focus.html
(right):

https://codereview.chromium.org/2628763003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/input/keyboard_event_without_focus.html:20:
// Insert |textField.value| to HTML for verification
On 2017/01/12 08:31:02, Xiaocheng wrote:
> I think we should modify assert_selection to report the actual value of
<input>
> (and probably <textarea>).
> 
> I'm not against it if you want to unblock
> https://codereview.chromium.org/2616623002 asap and fix the hack here later.

If assert_selection won't be used to test such
  input/textarea editing any more except this,
 it is bit overkill to impl that support in assert_selection.
(However, I guess assert_selection will:))
Then if we need one more layout test of input/textarea, we
 will impl in assert_selection.