Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2628763002: Replaced RefPtr::release with std::move in Source/wtf. (Closed)

Created:
3 years, 11 months ago by Bugs Nash
Modified:
3 years, 11 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced RefPtr::release with std::move in Source/wtf. Part of the removal of PassRefPtr. Replaces call to RefPtr::release with a std::move wrap, which returns a RefPtr instead of a PassRefPtr. As the code currently stands, the method return type is still a PassRefPtr, and so the PassRefPtr initialising constructor will be called passing in the RefPtr rvalue, which calls RefPtr::release anyway. Future patches will see these variables changed from PassRefPtr to RefPtr type then RefPtr::release will not be used at all. Does not handle RefPtr::release of non member variables in return statements as these cases sometimes default to move (in the case of returning a local variable). These will be handled in future patches. BUG=494719 Review-Url: https://codereview.chromium.org/2628763002 Cr-Commit-Position: refs/heads/master@{#443402} Committed: https://chromium.googlesource.com/chromium/src/+/4c98cd46c28088618ae90963e1d3708b6508f093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/text/StringBuffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Bugs Nash
3 years, 11 months ago (2017-01-11 05:05:01 UTC) #6
Yuta Kitamura
lgtm
3 years, 11 months ago (2017-01-12 10:31:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628763002/1
3 years, 11 months ago (2017-01-12 20:54:33 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:14:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c98cd46c28088618ae90963e1d3...

Powered by Google App Engine
This is Rietveld 408576698