Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

This patch moves implementations of |Document::execCommand()| and
|queryCommand*()| to "DocumentExecCommand.cpp" from "Document.cpp" to avoid
including "core/editing/Editor.h" in "Document.cpp" and reduce source code size
for making compilation of "Document.cpp" faster.

BUG=258591
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2628753002
Cr-Commit-Position: refs/heads/master@{#442854}
Committed: https://chromium.googlesource.com/chromium/src/+/cb36c4939dda375f028ae61a6817e10d7de39161

[yosin_UTC9, 2017-01-11 04:00:08]

Description was changed from

==========
2017-01-11T12:58:50

2017-01-11T12:58:41

BUG=
==========

to

==========
Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

This 

BUG=258591
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-11 04:00:22]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 04:01:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-11 04:02:13]

Description was changed from

==========
Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

This 

BUG=258591
TEST=n/a; no behavior changes
==========

to

==========
Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

This patch moves implementations of |Document::execCommand()| and
|queryCommand*()| to "DocumentExecCommand.cpp" from "Document.cpp" to avoid
including "core/editing/Editor.h" in "Document.cpp" and reduce source code size
for making compilation of "Document.cpp" faster.

BUG=258591
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-11 04:10:29]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-01-11 04:10:30]

PTAL

[commit-bot: I haz the power, 2017-01-11 04:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:45:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tkent, 2017-01-11 04:55:15]

lgtm.

Moving member function definitions to a file in another directory might be
confusing, but it's very simple way to split Document.cpp.

Other ideas would be:
 * Make STATIC_ONLY DocumentExecCommand class, and function definitions in
Document.cpp just call corresponding static functions of DocumentExecCommand.
 * Extract execCommand-related functions from Document.idl to
DocumentExecCommand.idl as a partial interface.

However, Patch Set 1 of this CL is much simpler than them.

[yosin_UTC9, 2017-01-11 05:48:27]

On 2017/01/11 at 04:55:15, tkent wrote:
> lgtm.
> 
> Moving member function definitions to a file in another directory might be
confusing, but it's very simple way to split Document.cpp.
> 
> Other ideas would be:
>  * Make STATIC_ONLY DocumentExecCommand class, and function definitions in
Document.cpp just call corresponding static functions of DocumentExecCommand.
>  * Extract execCommand-related functions from Document.idl to
DocumentExecCommand.idl as a partial interface.
> 
> However, Patch Set 1 of this CL is much simpler than them.

"partial interface" is attractive. But, it may increase build time.
So, I'll introduce DocumentExecCommand.idl later.

[yosin_UTC9, 2017-01-11 05:48:36]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-01-11 05:48:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-01-11 06:34:33]

On 2017/01/11 at 05:48:27, yosin wrote:
> >  * Extract execCommand-related functions from Document.idl to
DocumentExecCommand.idl as a partial interface.
> > 
> > However, Patch Set 1 of this CL is much simpler than them.
> 
> "partial interface" is attractive. But, it may increase build time.
> So, I'll introduce DocumentExecCommand.idl later.

Maybe we don't like to introduce a partial interface for execCommand because
we'd like to make our IDLs match to specifications as much possible.

[yosin_UTC9, 2017-01-11 07:58:08]

On 2017/01/11 at 06:34:33, tkent wrote:
> On 2017/01/11 at 05:48:27, yosin wrote:
> > >  * Extract execCommand-related functions from Document.idl to
DocumentExecCommand.idl as a partial interface.
> > > 
> > > However, Patch Set 1 of this CL is much simpler than them.
> > 
> > "partial interface" is attractive. But, it may increase build time.
> > So, I'll introduce DocumentExecCommand.idl later.
> 
> Maybe we don't like to introduce a partial interface for execCommand because
we'd like to make our IDLs match to specifications as much possible.

At first time, I think so too. But, the spec[1] doesn't have execCommand().
And the editing spec[2] have "interface" definition. The text implies
|execCommand()| in Document interface.

[1] https://www.w3.org/TR/dom/#interface-document
[2]
https://w3c.github.io/editing/execCommand.html#methods-to-query-and-execute-c...

Excerpt:
When the execCommand(command, show UI, value) method on the HTMLDocument
interface is invoked,
_________^^^^^^^^^^^________________________________________^^^^^^^^^^^^^^^^^^^^^^

It leads me, excCommand is at least defined in HTMLDocument and other
interfaces, e.g. Document, Node :-)

[yosin_UTC9, 2017-01-11 08:12:45]

On 2017/01/11 at 07:58:08, Yosi_UTC9 wrote:
> On 2017/01/11 at 06:34:33, tkent wrote:
> > On 2017/01/11 at 05:48:27, yosin wrote:
> > > >  * Extract execCommand-related functions from Document.idl to
DocumentExecCommand.idl as a partial interface.
> > > > 
> > > > However, Patch Set 1 of this CL is much simpler than them.
> > > 
> > > "partial interface" is attractive. But, it may increase build time.
> > > So, I'll introduce DocumentExecCommand.idl later.
> > 
> > Maybe we don't like to introduce a partial interface for execCommand because
we'd like to make our IDLs match to specifications as much possible.
> 
> At first time, I think so too. But, the spec[1] doesn't have execCommand().
> And the editing spec[2] have "interface" definition. The text implies
|execCommand()| in Document interface.
> 
> [1] https://www.w3.org/TR/dom/#interface-document
> [2]
https://w3c.github.io/editing/execCommand.html#methods-to-query-and-execute-c...
> 
> Excerpt:
> When the execCommand(command, show UI, value) method on the HTMLDocument
interface is invoked,
>
_________^^^^^^^^^^^________________________________________^^^^^^^^^^^^^^^^^^^^^^
> 
> It leads me, excCommand is at least defined in HTMLDocument and other
interfaces, e.g. Document, Node :-)

Found in WhatWG spec. I file https://github.com/w3c/editing/issues/159 to
execCommand spec to have interface definition.

[commit-bot: I haz the power, 2017-01-11 10:27:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484113716228970, "parent_rev":
"d710dfa964347e28493a6e5c8c41c4b8634996f0", "commit_rev":
"cb36c4939dda375f028ae61a6817e10d7de39161"}

[commit-bot: I haz the power, 2017-01-11 10:28:02]

Description was changed from

==========
Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

This patch moves implementations of |Document::execCommand()| and
|queryCommand*()| to "DocumentExecCommand.cpp" from "Document.cpp" to avoid
including "core/editing/Editor.h" in "Document.cpp" and reduce source code size
for making compilation of "Document.cpp" faster.

BUG=258591
TEST=n/a; no behavior changes
==========

to

==========
Move Document::execCommand() and queryCommand*() to "DocumentExecCommand.cpp"

This patch moves implementations of |Document::execCommand()| and
|queryCommand*()| to "DocumentExecCommand.cpp" from "Document.cpp" to avoid
including "core/editing/Editor.h" in "Document.cpp" and reduce source code size
for making compilation of "Document.cpp" faster.

BUG=258591
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2628753002
Cr-Commit-Position: refs/heads/master@{#442854}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb36c4939dda375f028ae61a6817...
==========

[commit-bot: I haz the power, 2017-01-11 10:28:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb36c4939dda375f028ae61a6817...