The great shader refactor: Use ProgramKey to initialize shaders

The great shader refactor: Use ProgramKey to initialize shaders

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2628713002
Cr-Commit-Position: refs/heads/master@{#443029}
Committed: https://chromium.googlesource.com/chromium/src/+/2d4b91cca2e8d886ca9fe64f58987448fe72289c

[ccameron, 2017-01-11 02:02:54]

Description was changed from

==========
The great shader refactor: Use ProgramKey to initialize shaders

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
==========

to

==========
The great shader refactor: Use ProgramKey to initialize shaders

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-01-11 02:03:31]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 03:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 03:49:54]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-01-11 07:14:08]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-01-11 07:14:09]

This is the prerequisite change that was causing problems earlier.

I've left TONS of DCHECKs in this one. They'll all be deleted in the next patch,
but it helps be sure that we're not changing any behavior here.

[enne (OOO), 2017-01-11 18:00:12]

On 2017/01/11 at 07:14:09, ccameron wrote:
> This is the prerequisite change that was causing problems earlier.

What was the problem? Was it just an incorrect setting in some program?

[enne (OOO), 2017-01-11 18:01:51]

Oh, meant to say that this still lgtm

[ccameron, 2017-01-11 18:40:41]

On 2017/01/11 18:00:12, enne wrote:
> On 2017/01/11 at 07:14:09, ccameron wrote:
> > This is the prerequisite change that was causing problems earlier.
> 
> What was the problem? Was it just an incorrect setting in some program?

I think that, cause the failures were just on Mac, it was probably
ignore_sampler_type_ (the thing that says "if it told you not to use
GL_TEXTURE_2D, ignore that, and use GL_TEXTURE_2D"), but I'm not sure. I feel
much safer with this version cause the DCHECKs guarantee that nothing changed
(at least on any shader that is ever compiled).

[ccameron, 2017-01-11 20:52:49]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:53:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:48:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484167969342910, "parent_rev":
"9b559c6994582ca25952810057dc778e82685ede", "commit_rev":
"2d4b91cca2e8d886ca9fe64f58987448fe72289c"}

[commit-bot: I haz the power, 2017-01-11 22:48:52]

Description was changed from

==========
The great shader refactor: Use ProgramKey to initialize shaders

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
The great shader refactor: Use ProgramKey to initialize shaders

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2628713002
Cr-Commit-Position: refs/heads/master@{#443029}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d4b91cca2e8d886ca9fe64f5898...
==========

[commit-bot: I haz the power, 2017-01-11 22:48:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d4b91cca2e8d886ca9fe64f5898...