[Mac] Hide Zoom Decoration for Default Zoom

[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should be set as invisible when the zoom is at the
default value.

BUG=666266
Review-Url: https://codereview.chromium.org/2628703002
Cr-Commit-Position: refs/heads/master@{#443694}
Committed: https://chromium.googlesource.com/chromium/src/+/d5a7a73975d123369dab9784b2897467a31b0ab8

[spqchan, 2017-01-11 19:42:46]

Description was changed from

==========
Hide zoom bubble

BUG=
==========

to

==========
Hide zoom bubble

BUG=
==========

[spqchan, 2017-01-11 19:47:09]

Description was changed from

==========
Hide zoom bubble

BUG=
==========

to

==========
[Mac] Hide Zoom Decoration for Default Zoom

Since there's no zoom decoration for the default zoom setting, the decoration
should
be hidden when the zoom is 100%.

BUG=666266
==========

[spqchan, 2017-01-11 19:47:09]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2017-01-11 19:47:13]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 19:48:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2017-01-11 19:49:36]

Description was changed from

==========
[Mac] Hide Zoom Decoration for Default Zoom

Since there's no zoom decoration for the default zoom setting, the decoration
should
be hidden when the zoom is 100%.

BUG=666266
==========

to

==========
[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should actually be hidden when the zoom is at the
default value.

BUG=666266
==========

[spqchan, 2017-01-11 19:49:36]

Description was changed from

==========
[Mac] Hide Zoom Decoration for Default Zoom

Since there's no zoom decoration for the default zoom setting, the decoration
should
be hidden when the zoom is 100%.

BUG=666266
==========

to

==========
[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should actually be hidden when the zoom is at the
default value.

BUG=666266
==========

[spqchan, 2017-01-11 20:33:40]

Description was changed from

==========
[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should actually be hidden when the zoom is at the
default value.

BUG=666266
==========

to

==========
[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should be set as invisible when the zoom is at the
default value.

BUG=666266
==========

[spqchan, 2017-01-11 20:33:47]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 20:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:57:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[spqchan, 2017-01-11 21:16:08]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 21:16:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spqchan, 2017-01-11 21:37:32]

PTAL

[commit-bot: I haz the power, 2017-01-11 22:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 22:25:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2017-01-11 22:33:16]

On 2017/01/11 21:37:32, spqchan wrote:
> PTAL

Whoops. Sorry, please hold the CL. It looks like there's another test I need to
fix.

[spqchan, 2017-01-12 19:12:15]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 19:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:22:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2017-01-12 22:17:02]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 22:18:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 23:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:45:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2017-01-12 23:47:44]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:49:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:59:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:59:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[spqchan, 2017-01-13 20:20:34]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[spqchan, 2017-01-13 20:20:44]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-13 20:21:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:05:17]

Dry run: This issue passed the CQ dry run.

[spqchan, 2017-01-13 21:12:32]

On 2017/01/11 22:33:16, spqchan wrote:
> On 2017/01/11 21:37:32, spqchan wrote:
> > PTAL
> 
> Whoops. Sorry, please hold the CL. It looks like there's another test I need
to
> fix.

Fixed the tests. PTAL, thanks!

[Robert Sesek, 2017-01-13 21:46:59]

Is it possible to add a regression test for this bug?

[spqchan, 2017-01-13 22:00:00]

On 2017/01/13 21:46:59, Robert Sesek wrote:
> Is it possible to add a regression test for this bug?

I was going to add a regression test, but then I realized that the
BubbleAtDefaultZoom browser test already covered it

[Robert Sesek, 2017-01-13 22:06:16]

LGTM

[spqchan, 2017-01-13 22:06:43]

On 2017/01/13 22:06:16, Robert Sesek wrote:
> LGTM

thanks!

[spqchan, 2017-01-13 22:06:48]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2017-01-13 22:07:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 22:13:43]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484345208544670,
"parent_rev": "5489020f1edea26f4256621b874afebf7425fdf0", "commit_rev":
"d5a7a73975d123369dab9784b2897467a31b0ab8"}

[commit-bot: I haz the power, 2017-01-13 22:14:30]

Description was changed from

==========
[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should be set as invisible when the zoom is at the
default value.

BUG=666266
==========

to

==========
[Mac] Hide Zoom Decoration for Default Zoom

The new zoom decoration has no icon for the default zoom setting.
As a result, it should be set as invisible when the zoom is at the
default value.

BUG=666266

Review-Url: https://codereview.chromium.org/2628703002
Cr-Commit-Position: refs/heads/master@{#443694}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5a7a73975d123369dab9784b289...
==========

[commit-bot: I haz the power, 2017-01-13 22:14:31]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d5a7a73975d123369dab9784b289...