Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2628673003: Use TaskScheduler instead of blocking pool in arc_downloads_watcher_service.cc. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Shuhei Takahashi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of blocking pool in arc_downloads_watcher_service.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: SKIP_ON_SHUTDOWN (default) Tasks posted with this mode that have not started executing at shutdown will never run. However, any task that has already begun executing when shutdown is invoked will be allowed to continue and will block shutdown until completion. Note: Previously, the task was posted to the blocking pool with BLOCK_SHUTDOWN (default in SequencedWorkerPool). May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=667892 Review-Url: https://codereview.chromium.org/2628673003 Cr-Commit-Position: refs/heads/master@{#443217} Committed: https://chromium.googlesource.com/chromium/src/+/feca15d2721db03086b94f3309d3926817a960bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fdoray
PTAL Blocking pool is being deprecated in favor of TaskScheduler.
3 years, 11 months ago (2017-01-11 21:14:35 UTC) #6
hidehiko
LGTM.
3 years, 11 months ago (2017-01-12 04:18:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628673003/1
3 years, 11 months ago (2017-01-12 13:24:45 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 13:28:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/feca15d2721db03086b94f3309d3...

Powered by Google App Engine
This is Rietveld 408576698