Enable networking.onc for autolaunched kiosk sessions (on dev)

Enable networking.onc for autolaunched kiosk sessions (on dev)

Enables networking.onc alias for networkingPrivate in kiosk sessions,
modulo few methods, whose implementation will keep requiring
networkingPrivate permissions (i.e. will be available only to
whitelisted set of apps). Methods in question are:
* deprecated methods - getVisibleNetworks
                     - getEnabledNetworkTypes
* Chromecast specific methods (so they can be moved to a separate
  namespace)
    - verifyDestination
    - verifyAndEncryptCredentials
    - verifyAndEncryptData
    - setWifiTDLSEnabledState
    - getWifiTDLSStatus

BUG=672186
Review-Url: https://codereview.chromium.org/2628673002
Cr-Commit-Position: refs/heads/master@{#443652}
Committed: https://chromium.googlesource.com/chromium/src/+/7628154b26186300379aa54027d019dd186f657d

[tbarzic, 2017-01-11 02:38:53]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:39:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:33:25]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tbarzic, 2017-01-11 19:37:31]

tbarzic@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, stevenjb@chromium.org

[stevenjb, 2017-01-11 20:03:20]

Nice. API and test changes lgtm.

[Devlin, 2017-01-12 21:41:06]

description nit: s/module/modulo?

https://codereview.chromium.org/2628673002/diff/20001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/2628673002/diff/20001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:35: return
extensions::ExtensionAPI::GetSharedInstance()
nitty nit: maybe just move the namespace extensions { on line 43 to line 19 and
remove these prefixes.

https://codereview.chromium.org/2628673002/diff/20001/extensions/common/api/_...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2628673002/diff/20001/extensions/common/api/_...
extensions/common/api/_permission_features.json:317: "channel": "stable",
this enables networking.onc on stable.  I think that should be separate to this
CL.

[tbarzic, 2017-01-12 21:42:37]

Description was changed from

==========
Enable networking.onc for autolaunched kiosk sessions (on dev)

Enables networking.onc alias for networkingPrivate in kiosk sessions,
module few methods, whose implementation will keep requiring
networkingPrivate permissions (i.e. will be available only to
whitelisted set of apps). Methods in question are:
* deprecated methods - getVisibleNetworks
                     - getEnabledNetworkTypes
* Chromecast specific methods (so they can be moved to a separate
  namespace)
    - verifyDestination
    - verifyAndEncryptCredentials
    - verifyAndEncryptData
    - setWifiTDLSEnabledState
    - getWifiTDLSStatus

BUG=672186
==========

to

==========
Enable networking.onc for autolaunched kiosk sessions (on dev)

Enables networking.onc alias for networkingPrivate in kiosk sessions,
modulo few methods, whose implementation will keep requiring
networkingPrivate permissions (i.e. will be available only to
whitelisted set of apps). Methods in question are:
* deprecated methods - getVisibleNetworks
                     - getEnabledNetworkTypes
* Chromecast specific methods (so they can be moved to a separate
  namespace)
    - verifyDestination
    - verifyAndEncryptCredentials
    - verifyAndEncryptData
    - setWifiTDLSEnabledState
    - getWifiTDLSStatus

BUG=672186
==========

[tbarzic, 2017-01-12 21:59:55]

https://codereview.chromium.org/2628673002/diff/20001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/2628673002/diff/20001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:35: return
extensions::ExtensionAPI::GetSharedInstance()
On 2017/01/12 21:41:05, Devlin wrote:
> nitty nit: maybe just move the namespace extensions { on line 43 to line 19
and
> remove these prefixes.

Done.

https://codereview.chromium.org/2628673002/diff/20001/extensions/common/api/_...
File extensions/common/api/_permission_features.json (right):

https://codereview.chromium.org/2628673002/diff/20001/extensions/common/api/_...
extensions/common/api/_permission_features.json:317: "channel": "stable",
On 2017/01/12 21:41:05, Devlin wrote:
> this enables networking.onc on stable.  I think that should be separate to
this
> CL.

yep, good point.

[Devlin, 2017-01-12 22:44:46]

lgtm

https://codereview.chromium.org/2628673002/diff/40001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/2628673002/diff/40001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:34: bool
HasPrivateNetworkingAccess(const Extension* extension,
It might be worth adding a comment why we do this (there are private methods
that shouldn't be exposed as part of onc). Although I suppose it's above each of
the call sites, so, up to you.

[tbarzic, 2017-01-12 22:59:46]

https://codereview.chromium.org/2628673002/diff/40001/extensions/browser/api/...
File extensions/browser/api/networking_private/networking_private_api.cc
(right):

https://codereview.chromium.org/2628673002/diff/40001/extensions/browser/api/...
extensions/browser/api/networking_private/networking_private_api.cc:34: bool
HasPrivateNetworkingAccess(const Extension* extension,
On 2017/01/12 22:44:45, Devlin wrote:
> It might be worth adding a comment why we do this (there are private methods
> that shouldn't be exposed as part of onc). Although I suppose it's above each
of
> the call sites, so, up to you.

Call sites do have comments stating reason these are restricted - I made them a
little clearer.

[tbarzic, 2017-01-13 19:22:36]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2017-01-13 19:22:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2628673002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2017-01-13 19:23:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 20:38:21]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484335356853660,
"parent_rev": "d97de8e6f3e1beba791dfdd6d7f2dd7160c45331", "commit_rev":
"7628154b26186300379aa54027d019dd186f657d"}

[commit-bot: I haz the power, 2017-01-13 20:38:57]

Description was changed from

==========
Enable networking.onc for autolaunched kiosk sessions (on dev)

Enables networking.onc alias for networkingPrivate in kiosk sessions,
modulo few methods, whose implementation will keep requiring
networkingPrivate permissions (i.e. will be available only to
whitelisted set of apps). Methods in question are:
* deprecated methods - getVisibleNetworks
                     - getEnabledNetworkTypes
* Chromecast specific methods (so they can be moved to a separate
  namespace)
    - verifyDestination
    - verifyAndEncryptCredentials
    - verifyAndEncryptData
    - setWifiTDLSEnabledState
    - getWifiTDLSStatus

BUG=672186
==========

to

==========
Enable networking.onc for autolaunched kiosk sessions (on dev)

Enables networking.onc alias for networkingPrivate in kiosk sessions,
modulo few methods, whose implementation will keep requiring
networkingPrivate permissions (i.e. will be available only to
whitelisted set of apps). Methods in question are:
* deprecated methods - getVisibleNetworks
                     - getEnabledNetworkTypes
* Chromecast specific methods (so they can be moved to a separate
  namespace)
    - verifyDestination
    - verifyAndEncryptCredentials
    - verifyAndEncryptData
    - setWifiTDLSEnabledState
    - getWifiTDLSStatus

BUG=672186

Review-Url: https://codereview.chromium.org/2628673002
Cr-Commit-Position: refs/heads/master@{#443652}
Committed:
https://chromium.googlesource.com/chromium/src/+/7628154b26186300379aa54027d0...
==========

[commit-bot: I haz the power, 2017-01-13 20:38:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7628154b26186300379aa54027d0...