Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: ui/webui/resources/cr_elements/cr_slider/cr_slider.html

Issue 2628633002: WebUI: cr-slider: Fix layout with large fonts (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/cr_elements/cr_slider/cr_slider.html
diff --git a/ui/webui/resources/cr_elements/cr_slider/cr_slider.html b/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
index 6f6bfc7fe79f13f2b10e6143a443510946d544fb..93c1d39d4215757987c6d2967a6960ba1175e081 100644
--- a/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
+++ b/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
@@ -10,34 +10,44 @@
display: flex;
flex-direction: column;
margin: 8px 0;
+ min-width: 200px;
}
- div.labels {
+ div#labels {
Dan Beam 2017/01/10 20:12:47 do you need this "div" at the beginning? what doe
stevenjb 2017/01/10 21:28:19 Done.
display: flex;
flex-direction: row;
justify-content: space-between;
margin: -4px 16px 0 16px;
}
- div.labels > div {
+ div#labels > div {
font-size: 12px;
Dan Beam 2017/01/10 20:12:47 why is this using a px-based font-size?
stevenjb 2017/01/10 21:28:19 It's not clear to me whether this should change wi
}
+ div#label-begin {
+ -webkit-margin-end: 4px;
+ }
+
+ div#label-end {
+ -webkit-margin-begin: 4px;
+ }
+
paper-slider {
/* Make the slider bar always grey. */
--paper-slider-active-color: var(--paper-grey-400);
/* Make the knob always blue. */
--paper-slider-knob-start-color: var(--google-blue-700);
--paper-slider-knob-start-border-color: var(--google-blue-700);
+ width: 100%;
}
</style>
<div class="outer">
<paper-slider id="slider" disabled="[[disabled]]" snaps
on-immediate-value-changed="onSliderChanged_">
</paper-slider>
- <div class="labels">
- <div>[[labelMin]]</div>
- <div>[[labelMax]]</div>
+ <div id="labels">
+ <div id="label-begin">[[labelMin]]</div>
+ <div id="label-end">[[labelMax]]</div>
</div>
</div>
</template>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698