Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: ui/webui/resources/cr_elements/cr_slider/cr_slider.html

Issue 2628633002: WebUI: cr-slider: Fix layout with large fonts (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/assert.html"> 1 <link rel="import" href="chrome://resources/html/assert.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-slider/paper-slid er.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-slider/paper-slid er.html">
4 4
5 <dom-module is="cr-slider"> 5 <dom-module is="cr-slider">
6 <template> 6 <template>
7 <style> 7 <style>
8 div.outer { 8 div.outer {
9 align-items: stretch; 9 align-items: stretch;
10 display: flex; 10 display: flex;
11 flex-direction: column; 11 flex-direction: column;
12 margin: 8px 0; 12 margin: 8px 0;
13 min-width: 200px;
13 } 14 }
14 15
15 div.labels { 16 div#labels {
Dan Beam 2017/01/10 20:12:47 do you need this "div" at the beginning? what doe
stevenjb 2017/01/10 21:28:19 Done.
16 display: flex; 17 display: flex;
17 flex-direction: row; 18 flex-direction: row;
18 justify-content: space-between; 19 justify-content: space-between;
19 margin: -4px 16px 0 16px; 20 margin: -4px 16px 0 16px;
20 } 21 }
21 22
22 div.labels > div { 23 div#labels > div {
23 font-size: 12px; 24 font-size: 12px;
Dan Beam 2017/01/10 20:12:47 why is this using a px-based font-size?
stevenjb 2017/01/10 21:28:19 It's not clear to me whether this should change wi
24 } 25 }
25 26
27 div#label-begin {
28 -webkit-margin-end: 4px;
29 }
30
31 div#label-end {
32 -webkit-margin-begin: 4px;
33 }
34
26 paper-slider { 35 paper-slider {
27 /* Make the slider bar always grey. */ 36 /* Make the slider bar always grey. */
28 --paper-slider-active-color: var(--paper-grey-400); 37 --paper-slider-active-color: var(--paper-grey-400);
29 /* Make the knob always blue. */ 38 /* Make the knob always blue. */
30 --paper-slider-knob-start-color: var(--google-blue-700); 39 --paper-slider-knob-start-color: var(--google-blue-700);
31 --paper-slider-knob-start-border-color: var(--google-blue-700); 40 --paper-slider-knob-start-border-color: var(--google-blue-700);
41 width: 100%;
32 } 42 }
33 </style> 43 </style>
34 <div class="outer"> 44 <div class="outer">
35 <paper-slider id="slider" disabled="[[disabled]]" snaps 45 <paper-slider id="slider" disabled="[[disabled]]" snaps
36 on-immediate-value-changed="onSliderChanged_"> 46 on-immediate-value-changed="onSliderChanged_">
37 </paper-slider> 47 </paper-slider>
38 <div class="labels"> 48 <div id="labels">
39 <div>[[labelMin]]</div> 49 <div id="label-begin">[[labelMin]]</div>
40 <div>[[labelMax]]</div> 50 <div id="label-end">[[labelMax]]</div>
41 </div> 51 </div>
42 </div> 52 </div>
43 </template> 53 </template>
44 <script src="chrome://resources/cr_elements/cr_slider/cr_slider.js"></script> 54 <script src="chrome://resources/cr_elements/cr_slider/cr_slider.js"></script>
45 </dom-module> 55 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698