Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2628583003: [ng_layout] Fix incorrect margin computation (Closed)

Created:
3 years, 11 months ago by atotic
Modified:
3 years, 11 months ago
Reviewers:
cbiesinger
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect margin computation This bug caused LayoutTest to fail: virtual/layout_ng/css2.1/20110323/absolute-replaced-width-055.htm BUG=635619 [ng_bug_margin_top] Review-Url: https://codereview.chromium.org/2628583003 Cr-Commit-Position: refs/heads/master@{#442726} Committed: https://chromium.googlesource.com/chromium/src/+/2d8a66165955cb54927f24e7ea53591a82177a99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
atotic
3 years, 11 months ago (2017-01-10 19:22:56 UTC) #3
cbiesinger
lgtm but if this fixes virtual/layout_ng/css2.1/20110323/absolute-replaced-width-055.htm can you remove it from TestExpectations?
3 years, 11 months ago (2017-01-10 19:47:13 UTC) #4
atotic
On 2017/01/10 at 19:47:13, cbiesinger wrote: > lgtm but if this fixes virtual/layout_ng/css2.1/20110323/absolute-replaced-width-055.htm can you ...
3 years, 11 months ago (2017-01-10 21:43:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628583003/1
3 years, 11 months ago (2017-01-10 21:43:36 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 23:35:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d8a66165955cb54927f24e7ea53...

Powered by Google App Engine
This is Rietveld 408576698