Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1269)

Issue 2628583002: Keep ranges_ptr variable for debug, not just the data it points to. (Closed)

Created:
3 years, 11 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep ranges_ptr variable for debug, not just the data it points to. BUG=600717 Review-Url: https://codereview.chromium.org/2628583002 Cr-Commit-Position: refs/heads/master@{#442627} Committed: https://chromium.googlesource.com/chromium/src/+/9d32d0bc1e2fbbad5ff6ba372ff386579d006cbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/metrics/histogram_snapshot_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
bcwhite
3 years, 11 months ago (2017-01-10 16:50:11 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-10 17:29:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628583002/1
3 years, 11 months ago (2017-01-10 17:46:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:50:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d32d0bc1e2fbbad5ff6ba372ff3...

Powered by Google App Engine
This is Rietveld 408576698