Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 2628493003: Revert of [foozzie] Pass startup test (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [foozzie] Pass startup test (patchset #1 id:1 of https://codereview.chromium.org/2623743004/ ) Reason for revert: Setting the BAD_BUILDS_CHECK env variable should be enough. Lets revert this as the code doesn't look particularly good. There must be another problem still that needs investigation. Original issue's description: > [foozzie] Pass startup test > > This makes sure the harness passes when called without test case. > > BUG=chromium:673246 > NOTRY=true > TBR=tandrii@chromium.org,mbarbella@chromium.org > > Review-Url: https://codereview.chromium.org/2623743004 > Cr-Commit-Position: refs/heads/master@{#42183} > Committed: https://chromium.googlesource.com/v8/v8/+/ede2fc1ff04ff97a466029b0ad52d3ec94780407 TBR=tandrii@chromium.org,mbarbella@chromium.org,mmoroz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:673246 Review-Url: https://codereview.chromium.org/2628493003 Cr-Commit-Position: refs/heads/master@{#42189} Committed: https://chromium.googlesource.com/v8/v8/+/e88e668e8130725247ce56fe40739d7ee1d308df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M tools/foozzie/v8_foozzie.py View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [foozzie] Pass startup test
3 years, 11 months ago (2017-01-10 17:18:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628493003/1
3 years, 11 months ago (2017-01-10 17:18:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/e88e668e8130725247ce56fe40739d7ee1d308df
3 years, 11 months ago (2017-01-10 17:19:05 UTC) #6
tandrii(chromium)
3 years, 11 months ago (2017-01-13 08:09:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698