Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2628473003: Fix irregexp build after r42140 (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix irregexp build after r42140 BUG=v8:5402 Review-Url: https://codereview.chromium.org/2628473003 Cr-Commit-Position: refs/heads/master@{#42165} Committed: https://chromium.googlesource.com/v8/v8/+/cd9ec3d29ceaf1f7aac38c4d1e83275bf85ce045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/regexp/interpreter-irregexp.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Yang
Thank you very much. LGTM.
3 years, 11 months ago (2017-01-10 09:49:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628473003/1
3 years, 11 months ago (2017-01-10 09:50:56 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 10:16:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cd9ec3d29ceaf1f7aac38c4d1e83275bf85...

Powered by Google App Engine
This is Rietveld 408576698