Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2628463002: [tracing] Use locale independent writer for FP values. (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tracing] Use locale independent writer for FP values. BUG=v8:5820 LOG=N Review-Url: https://codereview.chromium.org/2628463002 Cr-Commit-Position: refs/heads/master@{#42256} Committed: https://chromium.googlesource.com/v8/v8/+/51c5d913937272907d1cc83f72424bbd2846ca07

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/tracing/traced-value.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M test/cctest/test-traced-value.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
alph
3 years, 11 months ago (2017-01-09 22:34:29 UTC) #2
alph
Friendly ping!
3 years, 11 months ago (2017-01-12 07:33:49 UTC) #12
Yang
On 2017/01/12 07:33:49, alph wrote: > Friendly ping! lgtm. sorry for the delay.
3 years, 11 months ago (2017-01-12 07:41:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628463002/20001
3 years, 11 months ago (2017-01-12 07:42:48 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 08:09:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/51c5d913937272907d1cc83f72424bbd284...

Powered by Google App Engine
This is Rietveld 408576698