Remove ScopedVector from ui/events/.

Remove ScopedVector from ui/events/.

BUG=554289
Review-Url: https://codereview.chromium.org/2628393003
Cr-Commit-Position: refs/heads/master@{#443947}
Committed: https://chromium.googlesource.com/chromium/src/+/5fe8de4d4823f0b09ce11446cc913e485a70366b

[Avi (use Gerrit), 2017-01-13 22:40:40]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 22:41:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:17:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2017-01-13 23:18:40]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 23:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:39:11]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Avi (use Gerrit), 2017-01-13 23:41:44]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 23:42:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-01-13 23:53:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 23:53:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 00:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 00:47:40]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-14 00:49:42]

avi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Avi (use Gerrit), 2017-01-14 00:49:42]

https://codereview.chromium.org/2628393003/diff/60001/ui/events/gesture_detec...
File ui/events/gesture_detection/motion_event_buffer.cc (right):

https://codereview.chromium.org/2628393003/diff/60001/ui/events/gesture_detec...
ui/events/gesture_detection/motion_event_buffer.cc:69: auto first_kept_event =
std::partition_point(
Note that the queue is sorted by time, which means that we can use utility
functions that assume partitions. This means that this lookup is a binary search
rather than the linear search we were using before.

[sadrul, 2017-01-16 20:26:45]

lgtm

https://codereview.chromium.org/2628393003/diff/60001/ui/events/platform/plat...
File ui/events/platform/platform_event_source_unittest.cc (right):

https://codereview.chromium.org/2628393003/diff/60001/ui/events/platform/plat...
ui/events/platform/platform_event_source_unittest.cc:30:
std::unique_ptr<PlatformEvent> event = base::MakeUnique<PlatformEvent>();
Is MakeUnique<> preferred over using new with the ctor? (asking to make sure I
use the preferred approach, if there is one, in new code)

[Avi (use Gerrit), 2017-01-16 20:39:38]

https://codereview.chromium.org/2628393003/diff/60001/ui/events/platform/plat...
File ui/events/platform/platform_event_source_unittest.cc (right):

https://codereview.chromium.org/2628393003/diff/60001/ui/events/platform/plat...
ui/events/platform/platform_event_source_unittest.cc:30:
std::unique_ptr<PlatformEvent> event = base::MakeUnique<PlatformEvent>();
On 2017/01/16 20:26:44, sadrul wrote:
> Is MakeUnique<> preferred over using new with the ctor? (asking to make sure I
> use the preferred approach, if there is one, in new code)

Yes. https://www.chromium.org/developers/coding-style/cpp-dos-and-donts

MakeUnique makes ownership much more clear.

[Avi (use Gerrit), 2017-01-16 20:39:43]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-01-16 20:40:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 21:40:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484599183536440,
"parent_rev": "56732c5de584ab7b38ba694204beaf038669cf9c", "commit_rev":
"5fe8de4d4823f0b09ce11446cc913e485a70366b"}

[commit-bot: I haz the power, 2017-01-16 21:41:31]

Description was changed from

==========
Remove ScopedVector from ui/events/.

BUG=554289
==========

to

==========
Remove ScopedVector from ui/events/.

BUG=554289

Review-Url: https://codereview.chromium.org/2628393003
Cr-Commit-Position: refs/heads/master@{#443947}
Committed:
https://chromium.googlesource.com/chromium/src/+/5fe8de4d4823f0b09ce11446cc91...
==========

[commit-bot: I haz the power, 2017-01-16 21:41:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5fe8de4d4823f0b09ce11446cc91...