Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2628383002: Port a workaround for LLVM bug about libc free programs to lld. (Closed)

Created:
3 years, 11 months ago by krasin1
Modified:
3 years, 11 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port a workaround for LLVM bug about libc free programs to lld. Originally, the flag was Gold-specific, but recently we started to use lld in some cases, and therefore an lld-specific flag needs to be passed. BUG=607968 Review-Url: https://codereview.chromium.org/2628383002 Cr-Commit-Position: refs/heads/master@{#443727} Committed: https://chromium.googlesource.com/chromium/src/+/ca4c79a635761b65faecd49dbb6d7a82c14a3a95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/test/data/nacl/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
krasin1
3 years, 11 months ago (2017-01-13 17:57:43 UTC) #2
Mark Seaborn
LGTM
3 years, 11 months ago (2017-01-13 18:20:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628383002/1
3 years, 11 months ago (2017-01-13 18:25:18 UTC) #8
krasin1
On 2017/01/13 18:20:09, Mark Seaborn wrote: > LGTM Thank you, Mark!
3 years, 11 months ago (2017-01-13 18:29:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/348143)
3 years, 11 months ago (2017-01-13 20:15:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628383002/1
3 years, 11 months ago (2017-01-13 21:15:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628383002/1
3 years, 11 months ago (2017-01-13 22:22:44 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 23:46:51 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca4c79a635761b65faecd49dbb6d...

Powered by Google App Engine
This is Rietveld 408576698