|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by krasin1 Modified:
3 years, 11 months ago Reviewers:
Mark Seaborn CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPort a workaround for LLVM bug about libc free programs to lld.
Originally, the flag was Gold-specific, but recently we started to
use lld in some cases, and therefore an lld-specific flag needs to
be passed.
BUG=607968
Review-Url: https://codereview.chromium.org/2628383002
Cr-Commit-Position: refs/heads/master@{#443727}
Committed: https://chromium.googlesource.com/chromium/src/+/ca4c79a635761b65faecd49dbb6d7a82c14a3a95
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
krasin@chromium.org changed reviewers: + mseaborn@chromium.org
The CQ bit was checked by krasin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by krasin@chromium.org
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/13 18:20:09, Mark Seaborn wrote: > LGTM Thank you, Mark!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by krasin@chromium.org
The CQ bit was checked by krasin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484346148037950, "parent_rev":
"da15a397eb0f6f3f461a1076d859b6f895eef2db", "commit_rev":
"ca4c79a635761b65faecd49dbb6d7a82c14a3a95"}
Message was sent while issue was closed.
Description was changed from ========== Port a workaround for LLVM bug about libc free programs to lld. Originally, the flag was Gold-specific, but recently we started to use lld in some cases, and therefore an lld-specific flag needs to be passed. BUG=607968 ========== to ========== Port a workaround for LLVM bug about libc free programs to lld. Originally, the flag was Gold-specific, but recently we started to use lld in some cases, and therefore an lld-specific flag needs to be passed. BUG=607968 Review-Url: https://codereview.chromium.org/2628383002 Cr-Commit-Position: refs/heads/master@{#443727} Committed: https://chromium.googlesource.com/chromium/src/+/ca4c79a635761b65faecd49dbb6d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ca4c79a635761b65faecd49dbb6d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
