MacViews: Support MODAL_TYPE_WINDOW in dialog tests.

MacViews: Support MODAL_TYPE_WINDOW in dialog tests.

This requires implementing NativeWidgetMac::GetAllOwnedWidgets(), and
ensuring that it (and GetAllChildWidgets()) includes window modal sheets
when the parent window is a native NSWindow rather than a views::Widget.

GetAllOwnedWidgets() is almost the same as GetAllChildWidgets(). It's
needed because client code needs to call GetAllOwnedWidgets() on other
platforms to pick up "transient" child windows, and it should have
similar behaviour on mac (just without the transients), rather than be
NOTIMPLEMENTED().

BUG=681049
Review-Url: https://codereview.chromium.org/2628373002
Cr-Commit-Position: refs/heads/master@{#443724}
Committed: https://chromium.googlesource.com/chromium/src/+/67b5583718d2ed35011af6d7468068e3c0237166

[tapted, 2017-01-13 17:12:12]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 17:12:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 18:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 18:40:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-01-13 19:28:45]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 19:29:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-01-13 19:41:23]

Description was changed from

==========
MacViews: Implement NativeWidgetMac::GetAllOwnedWidgets()

This is almost the same as GetAllChildWidgets(). It's needed because
client code needs to call GetAllOwnedWidgets() on other platforms, and
it should behave the same on Mac.

BUG=
==========

to

==========
MacViews: Implement NativeWidgetMac::GetAllOwnedWidgets()

This is almost the same as GetAllChildWidgets(). It's needed because
client code needs to call GetAllOwnedWidgets() on other platforms, and
it should behave the same on Mac.

BUG=681049
==========

[tapted, 2017-01-13 19:45:12]

Description was changed from

==========
MacViews: Implement NativeWidgetMac::GetAllOwnedWidgets()

This is almost the same as GetAllChildWidgets(). It's needed because
client code needs to call GetAllOwnedWidgets() on other platforms, and
it should behave the same on Mac.

BUG=681049
==========

to

==========
MacViews: Support MODAL_TYPE_WINDOW in dialog tests

This requires implementing NativeWidgetMac::GetAllOwnedWidgets(), and
ensuring that it includes window modal sheets when the parent window is
a native NSWindow rather than a views::Widget.

GetAllOwnedWidgets() is almost the same as GetAllChildWidgets(). It's
needed because client code needs to call GetAllOwnedWidgets() on other
platforms to pick up "transient" child windows, and it should have
similar behaviour on mac (just without the transients).

BUG=681049
==========

[commit-bot: I haz the power, 2017-01-13 19:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 19:54:12]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-01-13 20:54:20]

Description was changed from

==========
MacViews: Support MODAL_TYPE_WINDOW in dialog tests

This requires implementing NativeWidgetMac::GetAllOwnedWidgets(), and
ensuring that it includes window modal sheets when the parent window is
a native NSWindow rather than a views::Widget.

GetAllOwnedWidgets() is almost the same as GetAllChildWidgets(). It's
needed because client code needs to call GetAllOwnedWidgets() on other
platforms to pick up "transient" child windows, and it should have
similar behaviour on mac (just without the transients).

BUG=681049
==========

to

==========
MacViews: Support MODAL_TYPE_WINDOW in dialog tests.

This requires implementing NativeWidgetMac::GetAllOwnedWidgets(), and
ensuring that it (and GetAllChildWidgets()) includes window modal sheets
when the parent window is a native NSWindow rather than a views::Widget.

GetAllOwnedWidgets() is almost the same as GetAllChildWidgets(). It's
needed because client code needs to call GetAllOwnedWidgets() on other
platforms to pick up "transient" child windows, and it should have
similar behaviour on mac (just without the transients), rather than be
NOTIMPLEMENTED().

BUG=681049
==========

[tapted, 2017-01-13 20:54:20]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[tapted, 2017-01-13 20:56:01]

Hi Robert - please take a look. This one is less mind-bendy - there's some
additional context in a follow-up for testing a window-modal sheet as part of a
DialogBrowserTest -
https://codereview.chromium.org/2625813003/diff/120001/chrome/browser/ui/test...

[Robert Sesek, 2017-01-13 21:10:09]

LGTM

[tapted, 2017-01-13 23:25:08]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:25:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:31:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484349908294140,
"parent_rev": "949dd87adb3934ef224e7c46ae823f1dab6c25bf", "commit_rev":
"67b5583718d2ed35011af6d7468068e3c0237166"}

[commit-bot: I haz the power, 2017-01-13 23:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:40:08]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[tapted, 2017-01-13 23:45:12]

Description was changed from

==========
MacViews: Support MODAL_TYPE_WINDOW in dialog tests.

This requires implementing NativeWidgetMac::GetAllOwnedWidgets(), and
ensuring that it (and GetAllChildWidgets()) includes window modal sheets
when the parent window is a native NSWindow rather than a views::Widget.

GetAllOwnedWidgets() is almost the same as GetAllChildWidgets(). It's
needed because client code needs to call GetAllOwnedWidgets() on other
platforms to pick up "transient" child windows, and it should have
similar behaviour on mac (just without the transients), rather than be
NOTIMPLEMENTED().

BUG=681049
==========

to

==========
MacViews: Support MODAL_TYPE_WINDOW in dialog tests.

This requires implementing NativeWidgetMac::GetAllOwnedWidgets(), and
ensuring that it (and GetAllChildWidgets()) includes window modal sheets
when the parent window is a native NSWindow rather than a views::Widget.

GetAllOwnedWidgets() is almost the same as GetAllChildWidgets(). It's
needed because client code needs to call GetAllOwnedWidgets() on other
platforms to pick up "transient" child windows, and it should have
similar behaviour on mac (just without the transients), rather than be
NOTIMPLEMENTED().

BUG=681049
Review-Url: https://codereview.chromium.org/2628373002
Cr-Commit-Position: refs/heads/master@{#443724}
Committed:
https://chromium.googlesource.com/chromium/src/+/67b5583718d2ed35011af6d74680...
==========

[tapted, 2017-01-13 23:45:32]

On 2017/01/13 23:40:08, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Added manually:

Review-Url: https://codereview.chromium.org/2628373002
Cr-Commit-Position: refs/heads/master@{#443724}
Committed:
https://chromium.googlesource.com/chromium/src/+/67b5583718d2ed35011af6d74680...

Closing CL.

[tapted, 2017-01-13 23:47:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67b5583718d2ed35011af6d74680...

(I want that purple line dammit!) #ocd