Cancel URLRequest with an appropriate code when WebSocket handshake succeeds

Cancel URLRequest with an appropriate code when WebSocket handshake succeeds

To notify the NetworkDelegate of WebSocket handshake success explicitly, this
CL introduces a new net error and cancels the URLRequest with it.

BUG=663672
Review-Url: https://codereview.chromium.org/2628333003
Cr-Commit-Position: refs/heads/master@{#444523}
Committed: https://chromium.googlesource.com/chromium/src/+/96205c442a254bfedf737c97f836c7bfd1973d29

[yhirano, 2017-01-13 09:57:17]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 09:57:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-13 10:01:26]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2017-01-13 10:01:34]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-13 10:02:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-13 10:42:02]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2017-01-13 10:42:07]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-13 10:42:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-13 10:45:15]

yhirano@chromium.org changed reviewers:
+ pkalinnikov@chromium.org, ricea@chromium.org

[yhirano, 2017-01-13 10:45:16]

+ricea@ for general review.
pkalinnikov@, is this what you want?

[Adam Rice, 2017-01-13 11:08:45]

lgtm

https://codereview.chromium.org/2628333003/diff/60001/net/websockets/websocke...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/2628333003/diff/60001/net/websockets/websocke...
net/websockets/websocket_stream.cc:156: // This is safe even if |this| has been
already destructed.
Grammar nit: "has already been deleted".

[yhirano, 2017-01-13 11:10:53]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 11:11:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-13 11:11:53]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 11:12:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-13 11:15:50]

https://codereview.chromium.org/2628333003/diff/60001/net/websockets/websocke...
File net/websockets/websocket_stream.cc (right):

https://codereview.chromium.org/2628333003/diff/60001/net/websockets/websocke...
net/websockets/websocket_stream.cc:156: // This is safe even if |this| has been
already destructed.
On 2017/01/13 11:08:44, Adam Rice wrote:
> Grammar nit: "has already been deleted".

Done.

[pkalinnikov, 2017-01-13 11:37:42]

LGTM.

Yes, this should be enough.

[commit-bot: I haz the power, 2017-01-13 12:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 12:08:38]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-01-13 12:22:25]

yhirano@chromium.org changed reviewers:
+ davidben@chromium.org

[yhirano, 2017-01-13 12:22:25]

+davidben@ for net/base/net_error_list.h

[yhirano, 2017-01-18 16:32:02]

davidben@, can you take a look?

[davidben, 2017-01-18 18:55:45]

Apologies, I somehow missed this. lgtm.

[pkalinnikov, 2017-01-18 19:50:03]

The CQ bit was checked by pkalinnikov@chromium.org

[pkalinnikov, 2017-01-18 19:50:04]

The patchset sent to the CQ was uploaded after l-g-t-m from ricea@chromium.org
Link to the patchset: https://codereview.chromium.org/2628333003/#ps100001
(title: "fix")

[commit-bot: I haz the power, 2017-01-18 19:51:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:45:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484769003857310,
"parent_rev": "1af3b5587d608b0417f3784703f8d389742cded0", "commit_rev":
"96205c442a254bfedf737c97f836c7bfd1973d29"}

[commit-bot: I haz the power, 2017-01-18 22:45:57]

Description was changed from

==========
Cancel URLRequest with an appropriate code when WebSocket handshake succeeds

To notify the NetworkDelegate of WebSocket handshake success explicitly, this
CL introduces a new net error and cancels the URLRequest with it.

BUG=663672
==========

to

==========
Cancel URLRequest with an appropriate code when WebSocket handshake succeeds

To notify the NetworkDelegate of WebSocket handshake success explicitly, this
CL introduces a new net error and cancels the URLRequest with it.

BUG=663672

Review-Url: https://codereview.chromium.org/2628333003
Cr-Commit-Position: refs/heads/master@{#444523}
Committed:
https://chromium.googlesource.com/chromium/src/+/96205c442a254bfedf737c97f836...
==========

[commit-bot: I haz the power, 2017-01-18 22:45:57]

Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/96205c442a254bfedf737c97f836...