Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2628323002: Remove DOMWindowProperty from WindowPaintWorklet (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DOMWindowProperty from WindowPaintWorklet WindowPaintWorklet doesn't need to inherit from DOMWindowProperty since it can retrieve a window object via Supplement<>. BUG=610176 Review-Url: https://codereview.chromium.org/2628323002 Cr-Commit-Position: refs/heads/master@{#443520} Committed: https://chromium.googlesource.com/chromium/src/+/2ee8b2c6aee296fd97c2064181aa77a240c98477

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-13 06:51:20 UTC) #3
haraken
This is the final user of DOMWindowProperty.
3 years, 11 months ago (2017-01-13 06:51:43 UTC) #5
sof
lgtm, well done :) https://codereview.chromium.org/2628323002/diff/1/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp File third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp (right): https://codereview.chromium.org/2628323002/diff/1/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp#newcode37 third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp:37: if (!m_paintWorklet && host() && ...
3 years, 11 months ago (2017-01-13 07:29:13 UTC) #6
haraken
On 2017/01/13 07:29:13, sof wrote: > lgtm, well done :) > > https://codereview.chromium.org/2628323002/diff/1/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp > File ...
3 years, 11 months ago (2017-01-13 07:34:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628323002/20001
3 years, 11 months ago (2017-01-13 07:35:55 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 09:04:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2ee8b2c6aee296fd97c2064181aa...

Powered by Google App Engine
This is Rietveld 408576698