Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2628313003: [Signin iOS] Handle unnamed account in Account Settings screen. (Closed)

Created:
3 years, 11 months ago by bzanotti
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Signin iOS] Handle unnamed account in Account Settings screen. The account full name might not have been fetched yet. Show the user email in the meantime. BUG=656994 Review-Url: https://codereview.chromium.org/2628313003 Cr-Commit-Position: refs/heads/master@{#443560} Committed: https://chromium.googlesource.com/chromium/src/+/f4fecb63fe8f3bc859b14a8d12d4de84d0b9e7c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bzanotti
Please take a look.
3 years, 11 months ago (2017-01-13 14:54:42 UTC) #2
lpromero
lgtm
3 years, 11 months ago (2017-01-13 15:06:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628313003/1
3 years, 11 months ago (2017-01-13 15:06:31 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 15:18:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4fecb63fe8f3bc859b14a8d12d4...

Powered by Google App Engine
This is Rietveld 408576698