Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2628313002: [Media] Plumb a feature parameter for the background video keyframe distance. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 04516c3553a8668b2449a533888b3ea3353b41d8..fc90b7e7ef992fcf49396b88aa58966a056bc9dd 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2907,6 +2907,10 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo) &&
!base::FeatureList::IsEnabled(features::kVrShell));
+ media_player->SetMaxKeyframeDistanceToDisableBackgroundVideo(
DaleCurtis 2017/01/13 20:34:13 Should this instead be part of WebMediaPlayerParam
whywhat 2017/01/13 21:10:54 That seemed like a smaller change, given the tempo
DaleCurtis 2017/01/14 00:28:04 It should always be used for one time values that
whywhat 2017/01/18 19:42:31 Ok, let me see how bigger the change will be due t
+ base::TimeDelta::FromSeconds(GetWebkitPreferences()
+ .max_keyframe_distance_to_disable_background_video_sec));
+
#if defined(OS_ANDROID) // WMPI_CAST
media_player->SetMediaPlayerManager(GetMediaPlayerManager());
media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());

Powered by Google App Engine
This is Rietveld 408576698