[Media] Plumb a feature parameter for the background video keyframe distance.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 2889 matching lines @@
       GetWebMediaPlayerDelegate()->AsWeakPtr(),
       std::move(media_renderer_factory), url_index_, params);
 
   // TODO(http://crbug.com/673886): Re-enable overlays with VR shell enabled
   // when VR shell's video reprojection surface is enabled. Remove the setter
   // and put the overlay feature check back in the constructor at that time.
   media_player->SetEnableFullscreenOverlays(
       base::FeatureList::IsEnabled(media::kOverlayFullscreenVideo) &&
       !base::FeatureList::IsEnabled(features::kVrShell));
 
+  media_player->SetMaxKeyframeDistanceToDisableBackgroundVideo(

[DaleCurtis, 2017/01/13 20:34:13]

Should this instead be part of WebMediaPlayerParams?

[whywhat, 2017/01/13 21:10:54]

That seemed like a smaller change, given the temporary nature of this code: it's
an experiment and we might be able to query the params directly in WMPI by EOQ.

I don't know when WMPParams should be used? Dan?

[DaleCurtis, 2017/01/14 00:28:04]

It should always be used for one time values that are never changed from
construction onward.

[whywhat, 2017/01/18 19:42:31]

Ok, let me see how bigger the change will be due to modifying the params ctor.

+      base::TimeDelta::FromSeconds(GetWebkitPreferences()
+          .max_keyframe_distance_to_disable_background_video_sec));
+
 #if defined(OS_ANDROID)  // WMPI_CAST
   media_player->SetMediaPlayerManager(GetMediaPlayerManager());
   media_player->SetDeviceScaleFactor(render_view_->GetDeviceScaleFactor());
   media_player->SetUseFallbackPath(use_fallback_path);
 #endif  // defined(OS_ANDROID)
 
 #if BUILDFLAG(ENABLE_MEDIA_REMOTING)
   remoting_controller_ptr->SetSwitchRendererCallback(base::Bind(
       &media::WebMediaPlayerImpl::ScheduleRestart, media_player->AsWeakPtr()));
   remoting_controller_ptr->SetRemoteSinkAvailableChangedCallback(base::Bind(
@@ skipping 3960 matching lines @@
   // event target. Potentially a Pepper plugin will receive the event.
   // In order to tell whether a plugin gets the last mouse event and which it
   // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
   // the event, it will notify us via DidReceiveMouseEvent() and set itself as
   // |pepper_last_mouse_event_target_|.
   pepper_last_mouse_event_target_ = nullptr;
 #endif
 }
 
 }  // namespace content