Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2628283003: Use new location of webrtc video frame headers, under webrtc/api. (Closed)

Created:
3 years, 11 months ago by nisse-chromium (ooo August 14)
Modified:
3 years, 9 months ago
Reviewers:
esprehn, hbos_chromium
CC:
chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new location of webrtc video frame headers, under webrtc/api. Replace a gn dependency on webrtc's common_video by video_frame_api. BUG=webrtc:5880 Review-Url: https://codereview.chromium.org/2628283003 Cr-Commit-Position: refs/heads/master@{#443552} Committed: https://chromium.googlesource.com/chromium/src/+/c3807d52dacc45aa76d0d0f23ddda973e3698288

Patch Set 1 #

Patch Set 2 : Add gn dependency on webrtc's video_frame_api. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/renderer/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/gpu/rtc_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_frame_adapter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
nisse-chromium (ooo August 14)
PTAL. This updates Chrome for new location and structure of the VideoFrame api.
3 years, 11 months ago (2017-01-13 08:01:57 UTC) #2
hbos_chromium
lgtm
3 years, 11 months ago (2017-01-13 08:47:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628283003/1
3 years, 11 months ago (2017-01-13 09:05:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/193846) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-13 09:09:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628283003/20001
3 years, 11 months ago (2017-01-13 09:15:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/363571)
3 years, 11 months ago (2017-01-13 11:25:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628283003/20001
3 years, 11 months ago (2017-01-13 12:11:15 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c3807d52dacc45aa76d0d0f23ddda973e3698288
3 years, 11 months ago (2017-01-13 14:04:50 UTC) #18
Wez
Hallo esprehn@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-07 19:47:51 UTC) #20
esprehn
3 years, 9 months ago (2017-03-21 17:39:27 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698