Revert of Use ChromeBrowserStateManager instead of BrowserListIOS.

Revert of Use ChromeBrowserStateManager instead of BrowserListIOS. (patchset #4 id:140001 of https://codereview.chromium.org/2615003002/ )

Reason for revert:
Breaks NewTabPagePerfTest.OpenNTP_Gentle

https://goto.google.com/cl-2615003002-breaks-perf-test

Original issue's description:
> Use ChromeBrowserStateManager instead of BrowserListIOS.
> 
> The BrowserListIOS was there as a parallel to BrowserList while the
> code was forked and is now only of historical interest as all of its
> methods can be implemented using ChromeBrowserStateManager.
> 
> The following rules were used when converting from BrowserListIOS to
> ChromeBrowserStateManager:
> 
> - re-implement BrowserListIOS::GetLastActiveWithBrowserState in term
>   of iterating over all ios::ChromeBrowserState registered with the
>   ChromeBrowserStateManager, and then over the TabModels associated
>   with those ios::ChromeBrowserState
> 
> - iteration over BrowserListIOS::begin()/BrowserListIOS::end() can be
>   replaced by iterating over the list from GetLoadedBrowserState() and
>   if off-the-record ios::ChromeBrowserState are wanted it, and for each
>   of them iterating over the TabModels associated
> 
> - BrowserListIOS::IsOffTheRecordSessionActive is re-implemented as
>   a free function implemented on top of ChromeBrowserStateManager using
>   the same rules.
> 
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2615003002
> Cr-Commit-Position: refs/heads/master@{#443590}
> Committed: https://chromium.googlesource.com/chromium/src/+/20f7270f96d194b98f3053a1f5035552cf758c2c

TBR=rohitrao@chromium.org,marq@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2628273004
Cr-Commit-Position: refs/heads/master@{#443728}
Committed: https://chromium.googlesource.com/chromium/src/+/e87dbcbbccc64f9fa09a7d5e607d50b446d63108

[Eugene But (OOO till 7-30), 2017-01-13 23:46:04]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-13 23:46:04]

Created Revert of Use ChromeBrowserStateManager instead of BrowserListIOS.

[commit-bot: I haz the power, 2017-01-13 23:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:47:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484351164113900, "parent_rev":
"ca4c79a635761b65faecd49dbb6d7a82c14a3a95", "commit_rev":
"e87dbcbbccc64f9fa09a7d5e607d50b446d63108"}

[commit-bot: I haz the power, 2017-01-13 23:48:14]

Description was changed from

==========
Revert of Use ChromeBrowserStateManager instead of BrowserListIOS. (patchset #4
id:140001 of https://codereview.chromium.org/2615003002/ )

Reason for revert:
Breaks NewTabPagePerfTest.OpenNTP_Gentle

https://goto.google.com/cl-2615003002-breaks-perf-test

Original issue's description:
> Use ChromeBrowserStateManager instead of BrowserListIOS.
> 
> The BrowserListIOS was there as a parallel to BrowserList while the
> code was forked and is now only of historical interest as all of its
> methods can be implemented using ChromeBrowserStateManager.
> 
> The following rules were used when converting from BrowserListIOS to
> ChromeBrowserStateManager:
> 
> - re-implement BrowserListIOS::GetLastActiveWithBrowserState in term
>   of iterating over all ios::ChromeBrowserState registered with the
>   ChromeBrowserStateManager, and then over the TabModels associated
>   with those ios::ChromeBrowserState
> 
> - iteration over BrowserListIOS::begin()/BrowserListIOS::end() can be
>   replaced by iterating over the list from GetLoadedBrowserState() and
>   if off-the-record ios::ChromeBrowserState are wanted it, and for each
>   of them iterating over the TabModels associated
> 
> - BrowserListIOS::IsOffTheRecordSessionActive is re-implemented as
>   a free function implemented on top of ChromeBrowserStateManager using
>   the same rules.
> 
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2615003002
> Cr-Commit-Position: refs/heads/master@{#443590}
> Committed:
https://chromium.googlesource.com/chromium/src/+/20f7270f96d194b98f3053a1f503...

TBR=rohitrao@chromium.org,marq@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
==========

to

==========
Revert of Use ChromeBrowserStateManager instead of BrowserListIOS. (patchset #4
id:140001 of https://codereview.chromium.org/2615003002/ )

Reason for revert:
Breaks NewTabPagePerfTest.OpenNTP_Gentle

https://goto.google.com/cl-2615003002-breaks-perf-test

Original issue's description:
> Use ChromeBrowserStateManager instead of BrowserListIOS.
> 
> The BrowserListIOS was there as a parallel to BrowserList while the
> code was forked and is now only of historical interest as all of its
> methods can be implemented using ChromeBrowserStateManager.
> 
> The following rules were used when converting from BrowserListIOS to
> ChromeBrowserStateManager:
> 
> - re-implement BrowserListIOS::GetLastActiveWithBrowserState in term
>   of iterating over all ios::ChromeBrowserState registered with the
>   ChromeBrowserStateManager, and then over the TabModels associated
>   with those ios::ChromeBrowserState
> 
> - iteration over BrowserListIOS::begin()/BrowserListIOS::end() can be
>   replaced by iterating over the list from GetLoadedBrowserState() and
>   if off-the-record ios::ChromeBrowserState are wanted it, and for each
>   of them iterating over the TabModels associated
> 
> - BrowserListIOS::IsOffTheRecordSessionActive is re-implemented as
>   a free function implemented on top of ChromeBrowserStateManager using
>   the same rules.
> 
> BUG=None
> 
> Review-Url: https://codereview.chromium.org/2615003002
> Cr-Commit-Position: refs/heads/master@{#443590}
> Committed:
https://chromium.googlesource.com/chromium/src/+/20f7270f96d194b98f3053a1f503...

TBR=rohitrao@chromium.org,marq@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2628273004
Cr-Commit-Position: refs/heads/master@{#443728}
Committed:
https://chromium.googlesource.com/chromium/src/+/e87dbcbbccc64f9fa09a7d5e607d...
==========

[commit-bot: I haz the power, 2017-01-13 23:48:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e87dbcbbccc64f9fa09a7d5e607d...

[sdefresne, 2017-01-16 09:38:46]

lgtm