Custom toString() methods may delete annots.

Custom toString() methods may delete annots.

In this case, we observe the destruction of the object, but have
unfortunately saved a pointer to it in a local variable. 

BUG=679643
Review-Url: https://codereview.chromium.org/2628233002
Committed: https://pdfium.googlesource.com/pdfium/+/192497124e7cde747ade7bf89028586eea293be5

[Tom Sepez, 2017-01-12 18:21:10]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 18:21:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-12 18:22:22]

Description was changed from

==========
Custom toString() methods may delete annots.

BUG=679643
==========

to

==========
Custom toString() methods may delete annots.

In this case, we observe the destruction of the object, but have
unfortunately saved a pointer to it in a local variable. 

BUG=679643
==========

[Tom Sepez, 2017-01-12 18:22:22]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:36:17]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-01-12 18:38:44]

Dan, for review.  See bug for details.

[dsinclair, 2017-01-12 19:14:39]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-12 19:14:40]

lgtm

https://codereview.chromium.org/2628233002/diff/1/fpdfsdk/javascript/Annot.cpp
File fpdfsdk/javascript/Annot.cpp (right):

https://codereview.chromium.org/2628233002/diff/1/fpdfsdk/javascript/Annot.cp...
fpdfsdk/javascript/Annot.cpp:52: vp >> bHidden;  // May invalidate m_pAnnot.
This seems like a crazy side effect. Should we log a bug to make the ToString
methods const?

[commit-bot: I haz the power, 2017-01-12 19:14:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:15:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484248479949840, "parent_rev":
"73debd4d226114b88430f2cc30dac056be5c13f3", "commit_rev":
"192497124e7cde747ade7bf89028586eea293be5"}

[commit-bot: I haz the power, 2017-01-12 19:15:08]

Description was changed from

==========
Custom toString() methods may delete annots.

In this case, we observe the destruction of the object, but have
unfortunately saved a pointer to it in a local variable. 

BUG=679643
==========

to

==========
Custom toString() methods may delete annots.

In this case, we observe the destruction of the object, but have
unfortunately saved a pointer to it in a local variable. 

BUG=679643

Review-Url: https://codereview.chromium.org/2628233002
Committed:
https://pdfium.googlesource.com/pdfium/+/192497124e7cde747ade7bf89028586eea29...
==========

[commit-bot: I haz the power, 2017-01-12 19:15:09]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/192497124e7cde747ade7bf89028586eea29...