Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2628173004: [NoStatePrefetch] Remove obsolete histograms (Closed)

Created:
3 years, 11 months ago by droger
Modified:
3 years, 11 months ago
Reviewers:
rkaplow, mattcary
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NoStatePrefetch] Remove obsolete histograms The NoStatePrefetchTTFCP are obsolete and don't conain any useful data. They have been replaced by PrefetchTTFCP histograms. Review-Url: https://codereview.chromium.org/2628173004 Cr-Commit-Position: refs/heads/master@{#443572} Committed: https://chromium.googlesource.com/chromium/src/+/8cea3f856adc43fdd72a9cda021c0ceaba3e3803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
droger
3 years, 11 months ago (2017-01-13 15:11:01 UTC) #6
mattcary
lgtm
3 years, 11 months ago (2017-01-13 15:17:13 UTC) #7
droger
+rkaplow as histograms.xml owner
3 years, 11 months ago (2017-01-13 15:24:24 UTC) #9
rkaplow
lgtm the code to emit these histograms has already been deleted?
3 years, 11 months ago (2017-01-13 15:58:04 UTC) #12
droger
Thanks. On 2017/01/13 15:58:04, rkaplow wrote: > lgtm > > the code to emit these ...
3 years, 11 months ago (2017-01-13 16:23:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628173004/20001
3 years, 11 months ago (2017-01-13 16:25:23 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:31:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8cea3f856adc43fdd72a9cda021c...

Powered by Google App Engine
This is Rietveld 408576698