Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2628173003: [wasm][asm.js] Make asm.js -> wasm message allocations predictable. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Make asm.js -> wasm message allocations predictable. We allocate console timing messages for now, as previously skipping this tickled unrelated flake. Use a fixed message to make them consistent in predictable mode. BUG=v8:4203 TBR=titzer@chromium.org Review-Url: https://codereview.chromium.org/2628173003 Cr-Commit-Position: refs/heads/master@{#42303} Committed: https://chromium.googlesource.com/v8/v8/+/87311b5cbaf4473b82d5d8556e5004247adc4d5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/asmjs/asm-js.cc View 2 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628173003/1
3 years, 11 months ago (2017-01-13 04:06:20 UTC) #5
bradn
3 years, 11 months ago (2017-01-13 04:07:50 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 04:52:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/87311b5cbaf4473b82d5d8556e5004247ad...

Powered by Google App Engine
This is Rietveld 408576698