Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2628153003: [ARM] Add tolerance to vrecpe, vrsqrte instruction tests. (Closed)

Created:
3 years, 11 months ago by bbudge
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add tolerance to vrecpe, vrsqrte instruction tests. The simulator implements these exactly, but on ARM hardware, the estimates are not exact, so CHECK_EQ will fail. This CL adds a tolerance to the checks. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2628153003 Cr-Commit-Position: refs/heads/master@{#42320} Committed: https://chromium.googlesource.com/v8/v8/+/497a7e4254cda8f5b0013c1545e8884bcc527068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M test/cctest/test-assembler-arm.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
bbudge
3 years, 11 months ago (2017-01-12 12:37:22 UTC) #3
martyn.capewell
lgtm It would be good to split the NEON tests soon, as they're getting difficult ...
3 years, 11 months ago (2017-01-13 10:55:51 UTC) #9
Michael Achenbach
lgtm stamp
3 years, 11 months ago (2017-01-13 11:05:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628153003/1
3 years, 11 months ago (2017-01-13 12:01:40 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:03:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/497a7e4254cda8f5b0013c1545e8884bcc5...

Powered by Google App Engine
This is Rietveld 408576698