third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2628153002: PlzNavigate: Fix anchor-no-multiple-windows.html layout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2628153002: PlzNavigate: Fix anchor-no-multiple-windows.html layout test. (Closed)

Patch Set: Update the shouldSendCompleteNotification() function to use the hasProvisionalNavigation() function Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 0cb62fd8e335545ffaf00c793c0686c16e556e38..1b3d3e756ab6cd64e3c4e705b3964408c03f3488 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -2029,7 +2029,7 @@ bool WebLocalFrameImpl::isLoading() const {

if (!frame() || !frame()->document())

return false;

return frame()->loader().stateMachine()->isDisplayingInitialEmptyDocument() ||

- frame()->loader().provisionalDocumentLoader() ||

+ frame()->loader().hasProvisionalNavigation() ||

!frame()->document()->loadEventFinished();

}

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »