third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2628153002: PlzNavigate: Fix anchor-no-multiple-windows.html layout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2628153002: PlzNavigate: Fix anchor-no-multiple-windows.html layout test. (Closed)

Patch Set: Update the shouldSendCompleteNotification() function to use the hasProvisionalNavigation() function Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index e664eb27cae54417d51390f29bb50218095ea927..0610418fd1c887b2c6234a917927ef78991a3ac6 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -706,8 +706,7 @@ static bool shouldSendCompleteNotification(LocalFrame* frame,

// Only send didStopLoading() if there are no navigations in progress at all,

// whether committed, provisional, or pending.

return frame->loader().documentLoader()->sentDidFinishLoad() &&

- !frame->loader().provisionalDocumentLoader() &&

- !isNavigationHandledByClient;

+ !frame->loader().hasProvisionalNavigation();

}

void FrameLoader::checkCompleted() {