[ios] Made goToItemAtIndex: safe for release builds.

[ios] Made goToItemAtIndex: safe for release builds.

Changed -[CRWWebController goToItemAtIndex:] to make no-op on release if
index is out of bound. This fully mirrors
NavigationControllerImpl::GoToIndex, which calls NOTREACHED() and early
returns for out of bounds indices.

BUG=677160
Review-Url: https://codereview.chromium.org/2628133003
Cr-Commit-Position: refs/heads/master@{#443732}
Committed: https://chromium.googlesource.com/chromium/src/+/d7658fd0442cce20cb16ada469d812a94655270a

[Eugene But (OOO till 7-30), 2017-01-12 17:41:19]

Description was changed from

==========
[ios] Removed canGoBack/canGoForward checks from chromeExecuteCommand.

Changed -[CRWWebController goToItemAtIndex:] to make no-op on release if
index is out of bound. This fully mirrors
NavigationControllerImpl::GoToIndex, which calls NOTREACHED() and early
returns for out of bounds indices.

BUG=677160
==========

to

==========
[ios] Made goToItemAtIndex: safe for release builds.

Changed -[CRWWebController goToItemAtIndex:] to make no-op on release if
index is out of bound. This fully mirrors
NavigationControllerImpl::GoToIndex, which calls NOTREACHED() and early
returns for out of bounds indices.

BUG=677160
==========

[Eugene But (OOO till 7-30), 2017-01-12 17:41:44]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 17:44:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-01-12 17:44:49]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-01-12 17:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 17:52:08]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-01-12 17:58:44]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 17:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 18:11:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:11:42]

Dry run: This issue passed the CQ dry run.

[kkhorimoto, 2017-01-13 23:45:37]

lgtm

[Eugene But (OOO till 7-30), 2017-01-13 23:47:11]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:47:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 00:00:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484351231075770,
"parent_rev": "828b1fae0b84215fdc1793a1a25ea3dd09d7bd2d", "commit_rev":
"d7658fd0442cce20cb16ada469d812a94655270a"}

[commit-bot: I haz the power, 2017-01-14 00:01:21]

Description was changed from

==========
[ios] Made goToItemAtIndex: safe for release builds.

Changed -[CRWWebController goToItemAtIndex:] to make no-op on release if
index is out of bound. This fully mirrors
NavigationControllerImpl::GoToIndex, which calls NOTREACHED() and early
returns for out of bounds indices.

BUG=677160
==========

to

==========
[ios] Made goToItemAtIndex: safe for release builds.

Changed -[CRWWebController goToItemAtIndex:] to make no-op on release if
index is out of bound. This fully mirrors
NavigationControllerImpl::GoToIndex, which calls NOTREACHED() and early
returns for out of bounds indices.

BUG=677160

Review-Url: https://codereview.chromium.org/2628133003
Cr-Commit-Position: refs/heads/master@{#443732}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7658fd0442cce20cb16ada469d8...
==========

[commit-bot: I haz the power, 2017-01-14 00:01:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d7658fd0442cce20cb16ada469d8...