MD WebUI: Move settings' dialog-drawer element into a shared cr-element

MD WebUI: Move settings' dialog-drawer element into a shared cr-element

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628123002
Cr-Commit-Position: refs/heads/master@{#443455}
Committed: https://chromium.googlesource.com/chromium/src/+/f13062d9f24f77c0262ec3ad3734c63c65c1bbe6

[tsergeant, 2017-01-12 01:08:12]

Description was changed from

==========
MD WebUI: Move settings' dialog-drawer element into a shared cr-element

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
==========

to

==========
MD WebUI: Move settings' dialog-drawer element into a shared cr-element

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-01-12 03:25:38]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2017-01-12 03:25:44]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 03:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:34:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:34:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-01-12 03:53:47]

tsergeant@chromium.org changed reviewers:
+ dpapad@chromium.org

[tsergeant, 2017-01-12 03:53:48]

dpapad@, please take a look! I'd like to use this element in History.

The failing try jobs are an unrelated problem with the CrOS compile.

[dpapad, 2017-01-12 22:38:12]

LGTM

[dpapad, 2017-01-12 22:38:57]

https://codereview.chromium.org/2628123002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/cr_elements/cr_drawer_tests.js (right):

https://codereview.chromium.org/2628123002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/cr_elements/cr_drawer_tests.js:5: suite('cr-drawer',
function() {
BTW, thanks for adding tests!

[tsergeant, 2017-01-12 22:53:51]

https://codereview.chromium.org/2628123002/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/cr_elements/cr_drawer_tests.js (right):

https://codereview.chromium.org/2628123002/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/cr_elements/cr_drawer_tests.js:5: suite('cr-drawer',
function() {
On 2017/01/12 22:38:57, dpapad wrote:
> BTW, thanks for adding tests!

No problem! I figured the existing test is pretty settings-specific, so adding
another one was worthwhile.

[tsergeant, 2017-01-12 22:53:56]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:55:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 23:58:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 23:59:01]

Failed to apply patch for
chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp:6
  error: chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp:
patch does not apply

Patch:      
chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
Index: chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
diff --git
a/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
b/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
index
45b699c284a9f2f57dff8dfc276d1ace2bce4904..199f94df1ec4a88c14b26aeb69d96533250403cf
100644
--- a/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
+++ b/chrome/browser/resources/settings/settings_ui/compiled_resources2.gyp
@@ -6,12 +6,12 @@
     {
       'target_name': 'settings_ui',
       'dependencies': [
+       
'<(DEPTH)/ui/webui/resources/cr_elements/cr_drawer/compiled_resources2.gyp:cr_drawer',
        
'<(DEPTH)/ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp:cr_toolbar',
        
'<(DEPTH)/ui/webui/resources/cr_elements/cr_toolbar/compiled_resources2.gyp:cr_toolbar_search_field',
         '../compiled_resources2.gyp:direction_delegate',
         '../compiled_resources2.gyp:global_scroll_target_behavior',
         '../prefs/compiled_resources2.gyp:prefs',
-        '../controls/compiled_resources2.gyp:dialog_drawer',
         '../settings_main/compiled_resources2.gyp:settings_main',
         'settings_ui_types',
       ],

[tsergeant, 2017-01-13 00:08:08]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-01-13 00:08:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2628123002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-13 00:09:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:55:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484266088572390,
"parent_rev": "7b28e26454b336fce8ad4eb8a5dd2597c0750eaa", "commit_rev":
"f13062d9f24f77c0262ec3ad3734c63c65c1bbe6"}

[commit-bot: I haz the power, 2017-01-13 01:56:24]

Description was changed from

==========
MD WebUI: Move settings' dialog-drawer element into a shared cr-element

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Move settings' dialog-drawer element into a shared cr-element

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628123002
Cr-Commit-Position: refs/heads/master@{#443455}
Committed:
https://chromium.googlesource.com/chromium/src/+/f13062d9f24f77c0262ec3ad3734...
==========

[commit-bot: I haz the power, 2017-01-13 01:56:26]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f13062d9f24f77c0262ec3ad3734...